Skip to content

Fix/page offset review followups #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MauroToscano merged 2 commits into from
Aug 6, 2026
Merged

Fix/page offset review followups #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a219e
drop the accidentally committed fix-acceptance.log'
jotabulacios Aug 6, 2026
0ca6744
docs(page): fix a doc comment on the wrong fn
jotabulacios Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions fix-acceptance.log
View file
Open in desktop

This file was deleted.

42 changes: 21 additions & 21 deletions prover/src/tables/page.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,27 @@ pub fn generate_page_trace_from_dense(
/// exist to force a human to ask "why did this change?" before the new
/// bytes get blessed. Re-pasting on a drift failure silently launders an
/// unintended table change into the verifier's compiled-in trust anchor.
pub(crate) fn static_zero_page_commitment(blowup_factor: u8) -> Option<Commitment> {
match blowup_factor {
2 => Some([
0x7d, 0x74, 0x85, 0xf0, 0x2b, 0x74, 0xe0, 0x3f, 0x14, 0x99, 0xb3, 0xa0, 0x5f, 0x1d,
0x6e, 0xf2, 0x21, 0xff, 0xaf, 0x24, 0x7e, 0x30, 0xb0, 0xda, 0x48, 0x79, 0xe1, 0x43,
0xee, 0xea, 0x6a, 0x0f,
]),
4 => Some([
0x5c, 0xcc, 0x5b, 0xb1, 0xe8, 0x11, 0x91, 0x81, 0xbd, 0xdd, 0x39, 0x40, 0x77, 0x87,
0xdc, 0x98, 0x06, 0x06, 0x8c, 0x63, 0xcd, 0xfd, 0xf1, 0xda, 0x4a, 0x55, 0x31, 0x4d,
0x6a, 0x16, 0x18, 0xd0,
]),
8 => Some([
0xf0, 0xc0, 0x69, 0xed, 0xf8, 0x59, 0xd6, 0x56, 0x15, 0x3c, 0x2f, 0x93, 0x65, 0xd6,
0xe9, 0xe9, 0x8e, 0xd1, 0x83, 0x94, 0xf9, 0x75, 0x59, 0xd1, 0xec, 0x16, 0xe1, 0x37,
0xd5, 0x32, 0xd6, 0xd9,
]),
_ => None,
}
}

/// Static OFFSET-only commitments for private-input pages, per `blowup_factor`.
///
/// Same provenance, regeneration rules and drift-test protection as
Expand All @@ -434,27 +455,6 @@ pub(crate) fn static_private_page_commitment(blowup_factor: u8) -> Option<Commit
}
}

pub(crate) fn static_zero_page_commitment(blowup_factor: u8) -> Option<Commitment> {
match blowup_factor {
2 => Some([
0x7d, 0x74, 0x85, 0xf0, 0x2b, 0x74, 0xe0, 0x3f, 0x14, 0x99, 0xb3, 0xa0, 0x5f, 0x1d,
0x6e, 0xf2, 0x21, 0xff, 0xaf, 0x24, 0x7e, 0x30, 0xb0, 0xda, 0x48, 0x79, 0xe1, 0x43,
0xee, 0xea, 0x6a, 0x0f,
]),
4 => Some([
0x5c, 0xcc, 0x5b, 0xb1, 0xe8, 0x11, 0x91, 0x81, 0xbd, 0xdd, 0x39, 0x40, 0x77, 0x87,
0xdc, 0x98, 0x06, 0x06, 0x8c, 0x63, 0xcd, 0xfd, 0xf1, 0xda, 0x4a, 0x55, 0x31, 0x4d,
0x6a, 0x16, 0x18, 0xd0,
]),
8 => Some([
0xf0, 0xc0, 0x69, 0xed, 0xf8, 0x59, 0xd6, 0x56, 0x15, 0x3c, 0x2f, 0x93, 0x65, 0xd6,
0xe9, 0xe9, 0x8e, 0xd1, 0x83, 0x94, 0xf9, 0x75, 0x59, 0xd1, 0xec, 0x16, 0xe1, 0x37,
0xd5, 0x32, 0xd6, 0xd9,
]),
_ => None,
}
}

/// Computes the Merkle root commitment over the LDE of PAGE precomputed columns.
///
/// The commitment covers OFFSET (0..page_size-1) and INIT (from config).
Expand Down
Loading