Review/ecsm ecdas corrections - #796
Merged
jotabulacios merged 3 commits intoJul 8, 2026
Merged
Conversation
NUM_COLUMNS is 667 after k widened 32 bytes -> 256 bit-columns and xg_sub_p (16 halfwords) was added. Comment-only; no behavior change.
The mu-gated R*P term (rq()) is applied in all three relations -- Lambda, Xr, and Yr (ecdas.rs s_i: Lambda/Xr/Yr all call rq()), not just lambda/xR. Comment-only; no behavior change.
The mu-gated p^2 term was multiplied by mu once per inner-loop term
(up to i+1 times per limb). Accumulate the constant sum first and apply
mu once per limb, mirroring ECDAS rq(). Algebraically identical
(mu distributes over the sum; p_byte_expr is a constant), degree
unchanged; ~Sum(i+1) fewer field muls per Yg limb over the LDE domain.
Validated: ecsm_tests::yg_padding_closes_via_mu_gated_p2_and_b,
constraints_hold_on_generated_trace, ecsm_constraint_set_folder_capture_agree,
and test_prove_elfs_ecsm{,_multi} + forged-mu rejection all pass.
diegokingston
marked this pull request as ready for review
July 8, 2026 20:49
jotabulacios
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.