query_selector cannot parse meta[property=og:title]

[mehmetcansahin]

Hi,
I cannot parse meta[property=og:title]. But alternatively I found this solution meta[property*=title]. What could I be doing wrong?

let node_option = self
            .dom
            .query_selector("meta[property=og:title]") or .query_selector(r#"meta[property="og:title"]"#)
            .and_then(|mut iter| iter.next());

[kelko]

As I took a look at that code not long ago, allow me to share some info: The parser for CSS selectors currently only accepts a sub-set of characters as attribute value:

let value = self.read_identifier();

Source

read_identifier checks if the value is_ident, which itself is defined as

pub fn is_ident(c: u8) -> bool {
    (b'0'..=b'9').contains(&c)
        || (b'A'..=b'Z').contains(&c)
        || (b'a'..=b'z').contains(&c)
        || c == b'-'
        || c == b'_'
}

Source

So the : is currently not accepted.

[y21]

afaik meta[property=og:title] isn't valid, however meta[property="og:title"] should work, but as @kelko pointed out the query selector only accepts identifiers right now. I think for this it makes sense to do what the HTML parser does for parsing attributes, and check if the value starts with " or ', and if it does, keep reading until it finds that quote. Only if it doesn't, read an identifier

[mehmetcansahin]

thanks @y21 and @kelko.