Skip to content

Add proxy configuration tips, wandb integration and refine task instructions - #53

Merged
HacksonClark merged 9 commits into
xlab-uiuc:mainfrom
Flemington8:main
Apr 22, 2025
Merged

HacksonClark merged 9 commits into
xlab-uiuc:mainfrom
Flemington8:main

Conversation

@Flemington8

@Flemington8 Flemington8 commented Apr 20, 2025 •

Copy link
Copy Markdown

Introduce Weights & Biases integration for session logging and orchestrator initialization. Update README and llm.py to support .env file for API key management. Refine task descriptions and instructions for smaller models to enhance format consistency and reduce errors. Include proxy configuration tips for AIOpsLab users.

Copilot AI review requested due to automatic review settings April 20, 2025 17:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a documentation section with proxy configuration tips for AIOpsLab users to help avoid issues when running VLLM and the LLM agent locally.

  • Introduces a "[Tips]" section in README.md
  • Provides recommendations on avoiding the use of the 172.17.0.1 address and handling SOCKS5 proxy connections
  • Advises on setting an environment variable (no_proxy) to prevent proxying localhost

Comment thread README.md
…e format consistency, reducing errors and improving compliance with required output structure
@Flemington8 Flemington8 changed the title Add proxy configuration tips for AIOpsLab users Add proxy configuration tips and refine task instructions Apr 21, 2025
@Flemington8
Flemington8 requested a review from Copilot April 21, 2025 05:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines task instructions across multiple task modules and adds proxy configuration tips to improve the developer experience when using AIOpsLab. Key changes include updated API call formatting instructions, language adjustments for task descriptions, and additional documentation on proxy settings in the README.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
clients/utils/templates.py Added important instructions for API call formatting
aiopslab/orchestrator/tasks/mitigation.py Refined task description and API call examples
aiopslab/orchestrator/tasks/localization.py Updated task instructions and clarified expected submission format
aiopslab/orchestrator/tasks/detection.py Minor text updates to align instruction language
aiopslab/orchestrator/tasks/analysis.py Revised task instructions and submission guidelines
aiopslab/orchestrator/actions/detection.py Updated parameter descriptions in the docstring
README.md Added proxy configuration tips and guidance for SOCKS5 usage
Comments suppressed due to low confidence (1)

aiopslab/orchestrator/tasks/localization.py:37

  • Consider clarifying the expected type by using list[str] (if appropriate) instead of list[] for a more explicit type description.
2. list[]: an empty list if no faults were detected

@Flemington8

Flemington8 commented Apr 21, 2025 •

Copy link
Copy Markdown
Author
=== Qwen2.5-Coder-3B-Instruct Error Parsing Analysis (Before Modification) ===
Total JSON files: 54
Total trace steps: 536
Total 'Error parsing' responses: 460
Error parsing ratio: 85.82%

=== Qwen2.5-Coder-3B-Instruct Error Parsing Analysis (After Modification) ===
Total JSON files: 207
Total trace steps: 924
Total 'Error parsing' responses: 1
Error parsing ratio: 0.11%

As you can see, the refinement of task descriptions and instructions could decrease the Error parsing ratio significantly.

@tianyin

tianyin commented Apr 21, 2025

Copy link
Copy Markdown
Member

@HacksonClark Can you review this PR?

Thanks for the contribution @Flemington8 !

@HacksonClark

Copy link
Copy Markdown
Collaborator

@Flemington8 Left some comments for you, overall looks great! I just think it's better if we make use_wandb into a .env variable instead of an argument, it keeps the code a lot cleaner. Once that is done I think this will be ready to merge.

@Flemington8 Flemington8 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flemington8 Left some comments for you, overall looks great! I just think it's better if we make use_wandb into a .env variable instead of an argument, it keeps the code a lot cleaner. Once that is done I think this will be ready to merge.

Great, thank you for your suggestion. This could make the code logic more concise!

@Flemington8 Flemington8 changed the title Add proxy configuration tips and refine task instructions Add proxy configuration tips, wandb integration and refine task instructions Apr 21, 2025
Comment thread aiopslab/orchestrator/orchestrator.py
Comment thread aiopslab/orchestrator/tasks/localization.py
Comment thread clients/gpt.py
Comment thread clients/gpt.py Outdated
@Flemington8

Flemington8 commented Apr 22, 2025 •

Copy link
Copy Markdown
Author

I have updated my PR follow your suggestion, is there any further modification I need to apply? @HacksonClark

@HacksonClark HacksonClark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@HacksonClark
HacksonClark merged commit d887517 into xlab-uiuc:main Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants