Repository navigation
Astronomy shop fixes - #52
Conversation
|
This PR also fixes the #48? |
|
@yinfangchen pops. I think I commented on the wrong issue. |
|
I thought we had an issue open about astronomy shop not working? I can't seem to find it anymore, too tired :( But this PR is a fix for astronomy shop. Basically, the install process wasn't initially set up. I also made a change to the fault injector so it restarts the pod ensuring the fault is injected, which i verified in logs and the flagd dashboard. One other issue was that the names in flagd don't match the docs, but after manually inspecting they should all be fixed. |
|
Tested in kind as well, working great! |
https://github.com/xlab-uiuc/agent-ops/issues/57
Have a rest and nite nite Hackson :) |
There were two issues. The first is with the deployment, it was assuming you had the helm charts locally, but I had never added it to aiopslab-applications. I first added it to aiopslab-applications, but I realized it's better if we support remote charts. So, I added a
remote_chartparameter to the helm interface.The second issue is that in the flagd config map, the faults don't match the feature flags on the website. Making that fix now.