Skip to content

Astronomy shop fixes - #52

Merged
yinfangchen merged 14 commits into
mainfrom
astronomy-shop-fixes
Apr 21, 2025
Merged

yinfangchen merged 14 commits into
mainfrom
astronomy-shop-fixes

Conversation

@HacksonClark

Copy link
Copy Markdown
Collaborator

There were two issues. The first is with the deployment, it was assuming you had the helm charts locally, but I had never added it to aiopslab-applications. I first added it to aiopslab-applications, but I realized it's better if we support remote charts. So, I added a remote_chart parameter to the helm interface.

The second issue is that in the flagd config map, the faults don't match the feature flags on the website. Making that fix now.

- productCatalogFailure: Fail product catalog service on a specific product
- recommendationCacheFailure: Fail recommendation service cache
- adManualGc: Triggers full manual garbage collections in the ad service
- adHighCpu: Triggers high cpu load in the ad service
- adFailure: Fail ad service
- kafkaQueueProblems: Overloads Kafka queue while simultaneously introducing a consumer side delay leading to a lag spike
- cartFailure: Fail cart service
- paymentFailure: Fail payment service charge requests n%
- paymentUnreachable: Payment service is unavailable
- loadGeneratorFloodHomepage: Flood the frontend with a large amount of requests.
- imageSlowLoad: slow loading images in the frontend

@HacksonClark HacksonClark self-assigned this Apr 18, 2025
@HacksonClark
HacksonClark marked this pull request as ready for review April 18, 2025 02:32
@HacksonClark HacksonClark linked an issue Apr 18, 2025 that may be closed by this pull request
@yinfangchen

Copy link
Copy Markdown
Member

This PR also fixes the #48?

@HacksonClark

Copy link
Copy Markdown
Collaborator Author

@yinfangchen pops. I think I commented on the wrong issue.

@HacksonClark

Copy link
Copy Markdown
Collaborator Author

I thought we had an issue open about astronomy shop not working? I can't seem to find it anymore, too tired :(

But this PR is a fix for astronomy shop. Basically, the install process wasn't initially set up. I also made a change to the fault injector so it restarts the pod ensuring the fault is injected, which i verified in logs and the flagd dashboard. One other issue was that the names in flagd don't match the docs, but after manually inspecting they should all be fixed.

@HacksonClark

Copy link
Copy Markdown
Collaborator Author

Tested in kind as well, working great!

@yinfangchen

Copy link
Copy Markdown
Member

I thought we had an issue open about astronomy shop not working?

https://github.com/xlab-uiuc/agent-ops/issues/57

too tired

Have a rest and nite nite Hackson :)

@yinfangchen yinfangchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinfangchen
yinfangchen merged commit 5d19677 into main Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_traces is not able to work in some tasks

2 participants