Repository navigation
Fix grid mappings after CF decoding - #673
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a dataset with
decode_coords="all"movesgrid_mappingfromattrstoencoding. After that,.cf.grid_mappingsraisesAttributeErroron DataArrays and returns empty coordinate associations on Datasets, although the API promises coordinate variable names.We now read associations from both metadata mappings, keeping
attrsprecedence and the declared order for multiple mappings.The regression test covers both accessors with single and multiple mappings, and the accessor suite passes.
Tested: cf-xarray main at b0ecc0d and xarray 2026.9.0.
— ChipLab