Repository navigation
Fix muted authors resurfacing through retweets - #9
Open
navigotechsolutions-labs wants to merge 1 commit into
Open
navigotechsolutions-labs wants to merge 1 commit into
navigotechsolutions-labs wants to merge 1 commit into
Conversation
## Summary `AuthorSocialgraphFilter` checked the viewer’s block list for `retweeted_user_id` but did not apply the viewer’s mute list. As a result, a post from a muted original author could resurface when another account retweeted it. ## Fix Apply `viewer_muted_user_ids` to `candidate.retweeted_user_id` and remove the candidate when the original retweeted author is muted. ## Tests Added regression coverage for both a muted retweeted author (removed) and an unmuted retweeted author (kept). `git diff --check` passes. The full Rust test suite could not be run in the local environment because this checkout does not expose a `home-mixer` Cargo manifest and the environment lacks `cargo`, `rustc`, and `rustfmt`.
Pitchfork-and-Torch
left a comment
Pitchfork-and-Torch
left a comment
There was a problem hiding this comment.
Review (COMMENT, not approve)
Applying viewer_muted_user_ids to retweeted_user_id matches the existing block check on the same field. Muted original authors should not re-enter For You via a third-party retweet.
Same asymmetry is still open for quotes: viewer_blocks_quoted_author exists, but there is no viewer_mutes_quoted_author on quoted_user_id. If you are already in this filter, adding mute-on-quote in the same PR (plus one test) would close the pair.
Regression tests for muted vs unmuted retweeted author are sufficient for this hole.
Verdict: support-with-gap. Take the retweet mute; please also cover quoted authors or say why quotes are intentionally different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthorSocialgraphFilterchecked the viewer’s block list forretweeted_user_idbut did not apply the viewer’s mute list. As a result, a post from a muted original author could resurface when another account retweeted it.Fix
Apply
viewer_muted_user_idstocandidate.retweeted_user_idand remove the candidate when the original retweeted author is muted.Tests
Added regression coverage for both a muted retweeted author (removed) and an unmuted retweeted author (kept).
git diff --checkpasses. The full Rust test suite could not be run in the local environment because this checkout does not expose ahome-mixerCargo manifest and the environment lackscargo,rustc, andrustfmt.