Repository navigation
Stop RankingScorer from ranking posts with no Phoenix heads - #142
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
Closed
Stop SubscriptionHydrator from skipping exclusive ids on retweets
Pitchfork-and-Torch/x-algorithm#40
Closed
Pitchfork-and-Torch
force-pushed
the
cursor/phoenix-ranker-fail-closed-372c
branch
from
September 8, 2026 23:11
0a42186 to
902a06f
Compare
Missing Phoenix scores used to become 0 and then NEGATIVE_SCORES_OFFSET, so lookup misses and a missing scoring_sequence still made TopK. Leave score unset so TopK drops them. Some(0.0) still ranks.
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Pitchfork-and-Torch
deleted the
cursor/phoenix-ranker-fail-closed-372c
branch
September 18, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Phoenix lookup miss, missing
scoring_sequence, or overflow pastPHOENIX_CLIENT_MAX_CANDIDATESleaves every Phoenix headNone.RankingScorer::applytreated that as 0, thenoffset_scorewroteSome(NEGATIVE_SCORES_OFFSET).TopKScoreSelectoronly dropsscore == None. Those posts still ranked.Some(0.0)is a real Phoenix prediction and still ranks.This is not #3 (ranker xDS). This is not #31 (author-size IPS). This is not a taste weight tweak.
Five-line proof
PhoenixScorer/predictions.candidate_scoresleave all heads None on missPhoenixCandidatePipelinescorers[PhoenixScorer, RankingScorer, VMRanker]thenTopKScoreSelector(score.unwrap_or(NEG_INFINITY))apply(None) = 0plus offset wrote a finite rank for an unscored postupdate_allalready skipsErr; prediction failure already returnedErrChange
RankingScorerandPhoenixScoresRankingScorer: no heads ->score/weighted_scorestayNonePhoenixScorer: missingscoring_sequencereturnsErrsoupdate_alldoes not stamp empty scores orlast_scored_at_msTests
Some(0.0)favorite: still rankscargo testcannot run. Public dump has no home-mixer crate manifest.Fork PR: none