Repository navigation
Wire ImpressedPostsQueryHydrator into Phoenix pipeline - #1
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreviouslySeenPostsBackupFilteris in the Phoenix candidate pipeline but no-ops whenquery.impressed_post_idsis empty.ImpressedPostsQueryHydratorwas constructed inbuild_with_clientsand then discarded (let _impressed_posts_hydrator = ...), so the backup seen-posts path never received IDs.This PR inserts the hydrator into
query_hydratorsnext toImpressionBloomFilterQueryHydratorand removes the unused binding. Prod and mock already passimpressed_posts_clientintobuild_with_clients.Hydrator and backup-filter unit tests already exist; no ranking/weight changes.
Test plan
ImpressedPostsQueryHydratorappears inPhoenixCandidatePipeline::build_with_clientsquery_hydrators_impressed_posts_hydratorbinding is goneimpressed_posts_query_hydrator.rsandpreviously_seen_posts_backup_filter.rsstill cover the components