Repository navigation
Give every radio's settings editor the same tabs (#131) - #135
Merged
Merged
Conversation
Only the radios with an APRS section were split into tabs; the rest were one long scroll, and the UV-5R and TD-H3 had no sections at all. Every profile editor now draws the same tabs in the same order — General, Display, Sounds, Transmit & Receive, Memory & VFO, Scan, DTMF & Signaling, Keys, Digital, GPS, APRS, Connections — showing only the ones a radio has fields for. - Each schema section names its tab with a `group`. A field names its own only where the OEM section mixes subjects (the TH-D75's "Common" holds TX power, scan resume and the backlight); those lead their tab unheaded. - The OEM section names stay as headings inside a tab. Field order in the generated schemas is untouched — several agreement tests zip it. - UV-5R, TD-H3 and D890UV are app-authored and are re-sectioned outright; the D890UV's 127-field "Other settings" is gone, and its 50 call-melody fields read "Tone N frequency/duration" under one heading per melody. - wiring.rs refuses a schema that opens without a section, or a section or field whose group is not in SETTINGS_GROUPS (read from profiles.ts). - The side nav, page title, Dashboard tile and in-app hints say "Radio Profiles" instead of "Radios". All 1,504 fields across the 11 radios land on exactly one tab, checked against the real schemas in the browser with IPC stubbed. No write path changes: settings are keyed by name, not position. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A heading that only repeats the tab's name is dropped for the tab's first section alone; a later one would read as part of the heading above it. - Fields borrowed from another tab's section now follow the tab's own sections, under their OEM heading whenever the tab draws headings. The ID-5100's "Data Speed" no longer floats above the Bluetooth heading. - Same setting, same tab: the D890UV boot screen moves to Display, QSO log is Digital on all three D-STAR radios, the ID-52's weather channels move to General beside the D890UV's NOAA channel, and time zone is GPS on all four radios that have one. - The untabbed layout is gone; a schema with no fields shows the existing "no configurable settings" message. - SettingField.group is typed as a SETTINGS_GROUPS member, so tsc refuses a misspelt tab. All 1,504 fields still land on exactly one tab, none twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131.
Only the radios with an APRS section had tabs; the rest were one long scroll, and the UV-5R and TD-H3 had no sections at all. Every profile editor now draws the same tabs in the same order, showing only the ones a radio has fields for:
General · Display · Sounds · Transmit & Receive · Memory & VFO · Scan · DTMF & Signaling · Keys · Digital · GPS · APRS · Connections
How
group. A field names its own only where the OEM section mixes subjects (the TH-D75's "Common" holds TX power, scan resume and the backlight); those lead their tab without a heading.wiring.rs: a schema must open with a section, and every section or fieldgroupmust be inSETTINGS_GROUPS(read fromsrc/lib/profiles.ts). Mutation-tested: a misspelt group fails it.CONTRIBUTING.mdand thenew-radioskill tell the next radio to setgroup.Verified
npm run cipasses locally (pre-push hook).Not verified / no hardware needed
🤖 Generated with Claude Code