Slim agent template and support Reforged map folders - #77
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6830a63baa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c262807f08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private fun ensureCompilerAgentDocs(compilerJar: Path) { | ||
| try { | ||
| JarFile(compilerJar.toFile()).use { jar -> | ||
| val entry = jar.getJarEntry(LANGUAGE_AGENT_DOC_ENTRY) ?: return |
There was a problem hiding this comment.
Remove stale language docs when the compiler omits them
When a compiler that contains agent-docs/WURST_LANGUAGE.md is replaced or downgraded to a compiler without that entry, this early return leaves the previously extracted file in place. Generated project notes then find the local file and treat it as compiler-matched instead of using the online fallback, potentially giving agents semantics from the wrong compiler version; delete the extracted file when the active JAR lacks the entry.
AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
AGENTS.mdfrom 251 lines / roughly 2,100 words to 73 lines / 788 wordsWURST_LANGUAGE.mdagent docs with an official manual fallbackgrill generateselection between a.w3xarchive and a.w3xmap folderwurst-project-templatebranches (masterandmap-folder)Why
The generated preset is loaded into every agent session, so detailed language and dependency material should be available on demand without crowding out project policy. Project generation also needs to reflect the two map storage modes supported by Warcraft III editors, with folder mode as the natural default for Reforged projects.
Impact
Generated projects now recommend map folders for Reforged patches and map archives for older patch targets. Users can override the choice interactively or with
--map-format archive|folder. The template documentation remains compact while retaining the language information agents need.Validation
./gradlew test --tests GenerateTests./gradlew testgit diff --check