Always run generate wizard with project name - #76
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
WurstSetup/src/main/kotlin/file/SetupApp.kt
Line 560 in afb92b1
Preserve CLI selections when wizard input is unavailable
Now that named generate runs the wizard, scripted invocations with stdin at EOF hit terminalPrompt() returning null for each wizard question; the wizard then treats those null answers as negative choices, so grill generate myproject --with-dep table-layout --with-agents --with-ci can generate a project without the requested dependency, AGENTS file, or CI workflow. Treat null like accepting the displayed default for named/project-flag flows, or skip optional prompts when no input is available.
AGENTS.md reference: AGENTS.md:L33-L34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
WurstSetup/src/main/kotlin/file/SetupApp.kt
Line 560 in 81c26d8
Preserve CLI patch selections in the wizard
When grill generate MyMap --wc3-patch v1.32 (or an exact Reforged-* dump) is run in an interactive terminal, this new unconditional wizard path sends the existing CLI patch into selectPatchVersion, but the interactive menu only contains recommended entries and falls back to default index 0 when the current patch is not recommended. Pressing Enter therefore silently overwrites the explicit CLI wc3Patch with v2.0; include the current/default patch in the menu choices as the text prompt does so named-project generation keeps the selected wc3Patch.
AGENTS.md reference: AGENTS.md:L33-L34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52b83ccd56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66311960cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 639e02c604
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74168ebade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| versions = patchTargets, | ||
| prompt = prompt, | ||
| exactVersions = versions | ||
| exactVersions = emptyList() |
There was a problem hiding this comment.
When the user types more and then exact in the text patch picker, this branch passes an empty list as exactVersions, but browsePatchVersions still treats exact as a command and recurses with that empty list, so the raw jass-history dump browser can no longer be reached from the supported-patch page. Pass the lazy fetched exact list here so users do not have to back out to the top-level prompt to browse raw dumps.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
WurstSetup/src/main/kotlin/file/SetupApp.kt
Line 564 in 166aaa2
Fall back to text prompts outside a TTY
When a project name is already supplied but the wizard input is piped or otherwise has no console, this now continues into runWizard with useInteractiveMenus = true. In that environment TerminalMenu.choose returns null, and selectPatchVersion treats that as cancel/default before reading from prompt, so a flow like printf 'jass\npre1.29\nnone\n...' | grill generate MyProject consumes jass for script mode, silently leaves wc3Patch at the default, then shifts pre1.29 into the Warcraft path prompt. Gate interactive menus on TerminalMenu.canUseInteractive() or fall back to the text patch prompt when menus cannot run.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e7f06dbed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| versions = patchTargets, | ||
| prompt = prompt, | ||
| exactVersions = versions | ||
| exactVersions = exactVersions |
There was a problem hiding this comment.
When the user types more, this argument evaluates the lazy exactVersions before browsePatchVersions can show the bundled supported patch list, so the supported-target browser still performs the raw jass-history GitHub lookup even if the user never asks for exact. In offline or slow-network sessions this stalls/warns before a local list that should be immediately available; pass a lazy provider and fetch only if exact is selected inside the browser.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
What changed
grill generatewizard, even when the project name is supplied as an argument.reference(value)for intentional shared mutation.Why
grill generate some-namereturned before enteringrunWizard, so it silently used defaults whilegrill generateprompted interactively. The template review also restores an explicit warning for the common closure-capture footgun and keeps the detailed bug/fix/reference examples.Validation
./gradlew test --tests GenerateTests