Re-add back ecs and code complexity for D10 #72

Activity

1. hkirsman

   added a commit that references this issue on May 26, 2023

   #72 Add back ecs package to composer.json.

   07746b9
2. hkirsman commented on May 26, 2023

   

   hkirsman

   on May 26, 2023

   ContributorAuthor

   More actions

   Probably this is needed:

       "wunderio/ecs-drupal": "^1.0",
       "symplify/coding-standard": "^11.3",
   

   Or at least let's start from latest 11.3.

   Then we also need to change that requirement here:

   https://github.com/wunderio/ecs-drupal/blob/master/composer.json

   Related issue at wunderio/ecs-drupal#2
3. hkirsman

   added 2 commits that reference this issue on May 27, 2023

   #72 Test out wunderio/ecs-drupal update.

   4de34e4

   #72 Test out wunderio/ecs-drupal update vol 2.

   e30440e
4. hkirsman commented on May 27, 2023

   

   hkirsman

   on May 27, 2023

   ContributorAuthor

   More actions

   Cognitive complexity used to need these lines

   
   services:
       -
           class: Symplify\CodingStandard\CognitiveComplexity\Rules\FunctionLikeCognitiveComplexityRule
           tags: [phpstan.rules.rule]
           arguments:
               maxMethodCognitiveComplexity: 16
       -
           class: Symplify\CodingStandard\CognitiveComplexity\Rules\ClassLikeCognitiveComplexityRule
           tags: [phpstan.rules.rule]
           arguments:
               maxClassCognitiveComplexity: 50
   

   It's yelling:
   Service (Symplify\CodingStandard\CognitiveComplexity\Rules\FunctionLikeCognitiveComplexityRule::__construct()): Class 'Symplify\CodingStandard\CognitiveComplexity\Rules\FunctionLikeCognitiveComplexityRule' not found.

   But seems they don't exist anymore and this might be the reason. New package is needed.

   https://github.com/symplify/symplify/pull/4515
5. hkirsman commented on May 27, 2023

   

   hkirsman

   on May 27, 2023

   ContributorAuthor

   More actions

   It might be even as simple as this to add back the cognitive complexity:

   https://github.com/TomasVotruba/cognitive-complexity
6. hkirsman commented on May 27, 2023

   

   hkirsman

   on May 27, 2023

   ContributorAuthor

   More actions

   Seems to work great:
   
7. hkirsman

   added 9 commits that reference this issue on May 29, 2023

   #72 Add tomasvotruba/cognitive-complexity.

   d9eecb3

   #72 Add tomasvotruba/cognitive-complexity.

   ab6b5dd

   #72 Fix code complexity in Psalm Drupal autoloader.

   f527429

   #72 Fix code complexity in Psalm Drupal autoloader.

   2c9c89c

   #72 Fix code complexity in Psalm Drupal autoloader.

   c93f7c0

   #72 Fix code complexity in Psalm Drupal autoloader.

   11101c9

   #72 Update class comment in DrupalAutoloaderBase.php.

   ada05a6

   #72 Try and fix signal 9 error.

   7e0472e

   #72 Change function cognitive complexity (see reasons in PR).

   cd89292
8. hkirsman

   added a commit that references this issue on May 7, 2024

   WD-257 Update ecs task to be used with Grumphp 2.5

   ...

   409f77f
9. hkirsman

   added a commit that references this issue on Oct 15, 2024

   Merge pull request #95 from wunderio/feature/72-Re-add-code-complexity

   ...

   b9acf69
10. hkirsman

    closed this as completedon Oct 15, 2024