Skip to content

Reject invalid Domain Paths in make-pot #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
Aug 3, 2026
Merged

Reject invalid Domain Paths in make-pot #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf0077
Reject invalid Domain Paths in make-pot
swissspidy Jul 29, 2026
37751d7
Update src/MakePotCommand.php
swissspidy Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions features/makepot.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,25 @@ Feature: Generate a POT file of a WordPress project
And STDERR should be empty
And the foo-plugin/languages/foo-plugin.pot file should exist

Scenario: Refuses Domain Path header with invalid path.
Given an empty foo-plugin directory
And a foo-plugin/foo-plugin.php file:
"""
<?php
/**
* Plugin Name: Foo Plugin
* Text Domain: foo-plugin
* Domain Path: ../../../../../../../../tmp/custom-languages
*/
"""

When I try `wp i18n make-pot foo-plugin`
Then STDERR should contain:
"""
Error: Invalid Domain Path value: ../../../../../../../../tmp/custom-languages
"""
And the return code should be 1

Scenario: Uses Text Domain header when no domain is set.
Given an empty foo-plugin directory
And a foo-plugin/foo-plugin.php file:
Expand Down
22 changes: 15 additions & 7 deletions src/MakePotCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,13 +393,21 @@ public function handle_arguments( $args, $assoc_args ) {
if ( isset( $this->main_file_data['Domain Path'] ) && is_array( $this->main_file_data['Domain Path'] ) ) {
$domain_path_val = $this->main_file_data['Domain Path']['value'] ?? '';
if ( is_scalar( $domain_path_val ) && ! empty( $domain_path_val ) ) {
// Domain Path inside source folder.
$this->destination = sprintf(
'%s/%s/%s.pot',
$this->source,
$this->unslashit( (string) $domain_path_val ),
$this->slug
);
$domain_path = $this->unslashit( Path::normalize( (string) $domain_path_val ) );

if ( preg_match( '#(?:^|/)\.\.(?:/|$)#', $domain_path ) || Path::is_absolute( $domain_path ) || Path::is_stream( $domain_path ) ) {
WP_CLI::error( sprintf( 'Invalid Domain Path value: %s', $domain_path_val ) );
}

if ( ! empty( $domain_path ) ) {
// Domain Path inside source folder.
$this->destination = sprintf(
'%s/%s/%s.pot',
$this->source,
$domain_path,
$this->slug
);
}
}
}

Expand Down
Loading