Repository navigation
119 Filename before the warning and full path to it - #361
elenachavdarova wants to merge 2 commits into
Conversation
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for the pull request, @elenachavdarova !
Can you update the existing functional tests so they pass?
Also, what do you think about using a relative path instead of the full path? I think a relative path (relative to the directory they're in) might be a little more developer-friendly.
|
Hello @danielbachhuber, As for the funcitonal tests - I checked the errors upon the failed tests and I am not sure how to include the full path (as it is a tmp one) to the expected output. I have updated the PR with file name moved to the start of the error. |
@elenachavdarova Sounds good!
This works for me. I'll leave this to @swissspidy for a final review. He's AFK for the next week or so though, so it might be a little bit. |
|
Closing as per #119 (comment) We can implement this in a new |
Included full path to the file and moved the path in the start of the warning.
Fixes: #119