Skip to content

wp user import-csv to be able to import CSV from STDIN - #100

Merged
danielbachhuber merged 2 commits into
masterfrom
patch-96
Oct 7, 2017
Merged

wp user import-csv to be able to import CSV from STDIN#100
danielbachhuber merged 2 commits into
masterfrom
patch-96

Conversation

@miya0001

@miya0001 miya0001 commented Oct 7, 2017 •
edited by danielbachhuber
Loading

Copy link
Copy Markdown
Member

Fixes #96

@miya0001 miya0001 mentioned this pull request Oct 7, 2017
Closed
@miya0001 miya0001 changed the title Patch 96 wp user import-csv to be able to import CSV from STDIN Oct 7, 2017
@miya0001
miya0001 requested a review from a team October 7, 2017 07:26
@danielbachhuber danielbachhuber added the command:user-import-csv Related to 'user import-csv' command label Oct 7, 2017
@danielbachhuber danielbachhuber added this to the 1.1.1 milestone Oct 7, 2017
@danielbachhuber
danielbachhuber merged commit dfedb1e into master Oct 7, 2017
@danielbachhuber
danielbachhuber deleted the patch-96 branch October 7, 2017 13:15
@gitlost

gitlost commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

A small thing I noticed is that the second has_stdin() check should be removed from the if ( '-' === $filename statement before the loop.

@miya0001 miya0001 mentioned this pull request Oct 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

command:user-import-csv Related to 'user import-csv' command

Projects

None yet

Milestone

1.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@miya0001 @gitlost @danielbachhuber