Replace manual temp path construction with Utils\make_temp_file()

[Copilot]

This updates core-command to use WP-CLI’s new temp-file helper instead of hand-built get_temp_dir() . uniqid() paths. The goal is to align with the newer API that creates temp files safely up front while keeping existing cleanup behavior unchanged.

• Scope: core download/update temp files
  • Swapped manual temp path generation in:
    • src/Core_Command.php (download temp .tmp)
    • src/Core_Command.php (skip-content working .zip)
    • src/WP_CLI/Core/CoreUpgrader.php (downloaded package extension)
• Behavioral intent
  • Preserve existing control flow and shutdown cleanup handlers.
  • Change only the temp-file creation mechanism.

// Before
$temp = Utils\get_temp_dir() . uniqid( 'wp_' ) . '.tmp';

// After
$temp = Utils\make_temp_file( 'wp_', '.tmp' );

• Fixes Use Utils\make_temp_file() for temporary paths #345

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5f44fb12-9ed9-4976-9a3f-54c819b63d9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

No unresolved issues were identified, and existing cleanup behavior is preserved.

Pull request overview

Replaces manual temporary-path construction with Utils\make_temp_file() for core downloads and updates while preserving cleanup behavior.

Changes:

• Updated download and skip-content temporary files.
• Updated core upgrader package temporary files.
• Preserved existing cleanup handlers.

File summaries

File	Description
src/WP_CLI/Core/CoreUpgrader.php	Uses Utils\make_temp_file() for downloaded packages.
src/Core_Command.php	Uses the helper for downloads and ZIP processing.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!