refactor: make MockHttpClientCall internal - #126
Open
MaxMichel2 wants to merge 1 commit into
Open
MaxMichel2 wants to merge 1 commit into
MaxMichel2 wants to merge 1 commit into
Conversation
MaxMichel2
force-pushed
the
refactor/mock-http-client-call-internal
branch
from
September 22, 2026 11:16
44b468d to
f86a085
Compare
MaxMichel2
changed the base branch from
main
to
feat/networkmock-sequential-mocks
September 22, 2026 11:16
MaxMichel2
added this pull request to stack #130
September 22, 2026 12:07
MockHttpClientCall was public purely because Ktor's HttpClientCall(client) base constructor requires it to be instantiable from the plugin's install code - nothing about it is meant to be integrator-facing, and its rawContent override already depends on the @InternalAPI-annotated Ktor API, so staying public compounded that instability risk onto this library's own public API surface. createMockHttpClientCall (the only caller) is already private in the same file, so this is a clean visibility narrowing with no call-site changes needed elsewhere. api.txt regenerated; no test or sample code constructed MockHttpClientCall directly. Closes #89. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
MaxMichel2
force-pushed
the
refactor/mock-http-client-call-internal
branch
from
September 22, 2026 12:51
f86a085 to
a5d6d4b
Compare
This was referenced Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #89.
MockHttpClientCallwaspublicpurely because Ktor'sHttpClientCall(client)base constructor requires it to be instantiable from the plugin's install code — nothing about it is meant to be integrator-facing. ItsrawContentoverride is already annotated@InternalAPI, meaning it depends on an unstable Ktor API; staying public compounded that instability onto this library's own tracked API surface.What changed
MockHttpClientCall→internal. Its only caller,createMockHttpClientCall, is alreadyprivatein the same file, so this is a clean visibility narrowing with no call-site changes needed elsewhere.devview-networkmock-ktor/api/api.txtregenerated viametalavaGenerateSignature—MockHttpClientCallno longer listed.devview-networkmock-ktor/CLAUDE.md.Verified no test or sample code constructs
MockHttpClientCalldirectly.Verification
All green.
🤖 Generated with Claude Code