This repository was archived by the owner on Sep 28, 2026. It is now read-only.
Port View Switcher to python - #109
Merged
Merged
Conversation
Contributor
|
Compare this PR and comments. |
Contributor
|
@imhemish nice to see you here, thank you for contributing yeah I'm afraid as @rolandlo pointed out this was already work in progress sonnyp/Workbench#726 EDIT: nevermind - I've reopen this one since it is open against the right repo We are sort of complete now with the Python port so if you want to contribute here are options
Here are source of inspirations #3 |
theCapypara
approved these changes
Feb 29, 2024
theCapypara
left a comment
theCapypara
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for your first contribution! Works perfectly & great idea to use get_ancestor
|
|
||
| def on_button_clicked(button: Gtk.Button, *_): | ||
| notifications_page.props.badge_number -= 1 | ||
| notification_list.remove(button.get_ancestor(Adw.ActionRow)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's my first time contributing to Workbench. Hope it's all good! Waiting for listening to any more suggestions or changes!