Skip to content

Add correct pin availability for ESP32 Mini modules #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
softhack007 merged 5 commits into from
Jan 6, 2025
Merged

Add correct pin availability for ESP32 Mini modules #4450

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0937064
fix pin availability calculations for ESP32-mini modules
ladyada Dec 31, 2024
d637260
typo fix
ladyada Dec 31, 2024
12db608
try debug
ladyada Dec 31, 2024
35d92f4
>sigh< https://github.com/espressif/arduino-esp32/issues/10683
ladyada Jan 3, 2025
dcf89e0
simplify logic
ladyada Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions wled00/pin_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,20 @@ bool PinManager::isPinOk(byte gpio, bool output)
// JTAG: GPIO39-42 are usually used for inline debugging
// GPIO46 is input only and pulled down
#else
if (gpio > 5 && gpio < 12) return false; //SPI flash pins
if (strncmp_P(PSTR("ESP32-PICO"), ESP.getChipModel(), 10) == 0 && (gpio == 16 || gpio == 17)) return false; // PICO-D4: gpio16+17 are in use for onboard SPI FLASH

if ((strncmp_P(PSTR("ESP32-U4WDH"), ESP.getChipModel(), 11) == 0) || // this is the correct identifier, but....
(strncmp_P(PSTR("ESP32-PICO-D2"), ESP.getChipModel(), 13) == 0)) { // https://github.com/espressif/arduino-esp32/issues/10683
// this chip has 4 MB of internal Flash and different packaging, so available pins are different!
if (((gpio > 5) && (gpio < 9)) || (gpio == 11))
return false;
} else {
// for classic ESP32 (non-mini) modules, these are the SPI flash pins
if (gpio > 5 && gpio < 12) return false; //SPI flash pins
}

if (((strncmp_P(PSTR("ESP32-PICO"), ESP.getChipModel(), 10) == 0) ||

@DedeHai DedeHai Jan 4, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between "ESP32-PICO" and "ESP32-PICO-D2" which both also correspond to "ESP32-U4WDH"? the double checking is a bit confusing to me, can you add comments on why this is needed?

@softhack007 softhack007 Jan 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DedeHai I can explain partially; there are actually 3 PICO boards:

  • ESP32-PICO-D4 (already supported)
  • ESP32-PICO-V3-02 (our old framework does not support this type)
  • ESP32-PICO-D2 (older frameworks wrongly identify the ESP32-U4WDH as PICO-D2)

All PICO boards, plus the U4WDH, have in common that gpio 16+17 are reserved for internal SPI flash. So blocking 16+17 for all these variants is correct.

(strncmp_P(PSTR("ESP32-U4WDH"), ESP.getChipModel(), 11) == 0))
&& (gpio == 16 || gpio == 17)) return false; // PICO-D4/U4WDH: gpio16+17 are in use for onboard SPI FLASH
if (gpio == 16 || gpio == 17) return !psramFound(); //PSRAM pins on ESP32 (these are IO)
#endif
if (output) return digitalPinCanOutput(gpio);
Expand Down