You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ext shortcuts: shortcuts dialog: List items text color is black #4
Since this is due to the reason I decided to apply theme to the shortcut dialog:
Do you like the themed shortcut dialog better?
If so, I'll be keeping the themed dialog, but that means I have to compromise the list view background somehow.
If not, I might just not theme it and problem solved.
One solution I can think of right now, is to just override the list view background to the default control colour, but I'm not sure how that will look on custom themes.
It would be too complicated to change the hardcoded text colours (black, green and red) to contrast with the custom colours.
Well, I appreciate the effort and I think that eventually it would be nice if entire UI can be themed. Unfortunately there are some areas where theme support is limited (not implemented, or really hard to implement) - e.g. colors of group titles in Results panel can't be customized (according to @Neverbirth) due to limitations of the control - making them hard to read if the Results panel has a dark background.
If having to choose between custom theme and readability, for me readability wins.
Personally I'm ok with a non-themed dialog, if it's simpler, since it's not used often anyway.
But if the dialog is a list, what is the difference with other themed lists in the project? Those allow to specify fore and back colors in the theme.
Firstly, the difference is that there are three fore colours being used by the list in the shortcut dialog. Those are currently hard-coded to be black (normal), green (modified) and red (conflicts). However it is possible to introduce themes for the hard-coded colours.
Secondly, the new shortcut dialog uses groups - like the results panel. That means there is that blue text just stuck there. Even p/invoke can't change the group title colour.
This is pretty much the reason I didn't really decide to introduce themes for the fore colours either; there is going to be an unmodifiable colour, so didn't really bother to make others modifiable...
However I do agree that it's nice to have the entire UI themed. Theming the shortcut dialog was done to take a step in that direction.
So I will eventually introduce themes for the fore colours. (I can just ignore the group title colour like the results panel.) But that would be at the end, when I make this branch into a PR, so not so soon.
Got it. If you make fore colors customizable, I will update my solarized theme.
Groups in results panel (and here) being not customizable is a really big shit from Microsoft... I hope one day FD will have it's own component with this functionality.
Activity
wise0704 commentedon Jun 19, 2017
Since this is due to the reason I decided to apply theme to the shortcut dialog:
Do you like the themed shortcut dialog better?
If so, I'll be keeping the themed dialog, but that means I have to compromise the list view background somehow.
If not, I might just not theme it and problem solved.
One solution I can think of right now, is to just override the list view background to the default control colour, but I'm not sure how that will look on custom themes.
It would be too complicated to change the hardcoded text colours (black, green and red) to contrast with the custom colours.
gene-pavlovsky commentedon Jun 19, 2017
Well, I appreciate the effort and I think that eventually it would be nice if entire UI can be themed. Unfortunately there are some areas where theme support is limited (not implemented, or really hard to implement) - e.g. colors of group titles in Results panel can't be customized (according to @Neverbirth) due to limitations of the control - making them hard to read if the Results panel has a dark background.
If having to choose between custom theme and readability, for me readability wins.
Personally I'm ok with a non-themed dialog, if it's simpler, since it's not used often anyway.
But if the dialog is a list, what is the difference with other themed lists in the project? Those allow to specify fore and back colors in the theme.
wise0704 commentedon Jun 21, 2017
Firstly, the difference is that there are three fore colours being used by the list in the shortcut dialog. Those are currently hard-coded to be black (normal), green (modified) and red (conflicts). However it is possible to introduce themes for the hard-coded colours.
Secondly, the new shortcut dialog uses groups - like the results panel. That means there is that blue text just stuck there. Even p/invoke can't change the group title colour.
This is pretty much the reason I didn't really decide to introduce themes for the fore colours either; there is going to be an unmodifiable colour, so didn't really bother to make others modifiable...
However I do agree that it's nice to have the entire UI themed. Theming the shortcut dialog was done to take a step in that direction.
So I will eventually introduce themes for the fore colours. (I can just ignore the group title colour like the results panel.) But that would be at the end, when I make this branch into a PR, so not so soon.
gene-pavlovsky commentedon Jun 21, 2017
Got it. If you make fore colors customizable, I will update my solarized theme.
Groups in results panel (and here) being not customizable is a really big shit from Microsoft... I hope one day FD will have it's own component with this functionality.