Fix digital screen color modes - #3706
Merged
Merged
Conversation
Contributor
|
Why would it broke at all? I can't find any parts of code that use these global values |
Contributor
Author
|
I can give you a recording if you want. Changing the code back and forth causes the bug. There's something wrong with what you did that I can't see either, but it is definitely wrong. |
Contributor
Author
|
Oops, we both fixed it at the same time. |
Contributor
|
Should be fine now, the issue was wrong return order |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3705 broke rendering with digital screens. This reverts those breaking changes.
Here is a screenshot of what the breaking changes do to images:
