Repository navigation
Remove the unused WiX MSI project - #25
Open
rodchristiansen wants to merge 1 commit into
Open
rodchristiansen wants to merge 1 commit into
rodchristiansen wants to merge 1 commit into
Conversation
build.ps1 builds every package, the MSI included, with cimipkg from build-info.yaml and scripts/, and nothing references build/msi. The WiX project, its Package.wxs and its copy of postinstall.ps1 had drifted from the shipped scripts, so they are deleted along with their .gitignore entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of removing WiX from the windowsadmins repos.
build/msi/StartSet.wixproj,Package.wxsandbuild/msi/postinstall.ps1are dead code.build.ps1builds every package, the MSI included, through cimipkg frombuild-info.yamlandscripts/, and nothing referencesbuild/msi. The copy ofpostinstall.ps1there had also drifted fromscripts/postinstall.ps1(93 lines against 172).What changed
build/msi..gitignoreentry.DataDirectoryGuard.csno longer mentions a separate MSI. The package postinstall applies the same root ACL withicacls.What stays the same
The shipped package is unchanged. cimipkg builds it with identifier
com.github.windowsadmins.startset, andscripts/postinstall.ps1still installs the service, PATH and ACLs. No release ever shipped a WiX MSI: every release since v2026.06.11 ships onlystartset-x64.zipandstartset-arm64.zip, which I checked through the releases API. So the WiX UpgradeCode7E4F8A2D-…needs nosupersedesentry.Tested
dotnet test StartSet.sln -c Releaseon a Windows 11 26200 x64 build host: 303 passed, 0 failed.git grep -i wixandgit grep build/msifind nothing in the tree.gh api repos/windowsadmins/startset/releases. They contain no MSI.Not tested
build.ps1,build-info.yamlandscripts/are byte-identical to main. Installing would also hit the VBScript limitation in Sandbox 26100 (error 2738).