Repository navigation
Let the duration policy take -1 for never delete - #38
Merged
Merged
Conversation
An ADMX decimal is unsigned, so the default rule's duration policy could not say -1, which configs use to mean never delete. It is now a text element writing REG_SZ, which the resolver already parses as a whole number. Rule durations in the Policies value already accept -1; the test now covers both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultPolicyDurationDayswas an ADMXdecimal, which is unsigned, so the policy could not express-1(never delete), which configs use asduration_days: -1.text(REG_SZ), same valueName and element idDefaultPolicyDurationDays_Value.SettingsResolveralready parses a REG_SZ whole number, and the engine treats any negative duration as never delete.textBoxdefaulting to 28, and the explain text says -1 = never delete.duration_daysinside thePoliciesvalue already accepts -1; the test sample now uses it.AdmxTestschecks the element is text and that"-1"resolves as -1 from policy. README's settings table lists the REG_SZ form.