Skip to content

Report simulations as what they would remove, list each account once, and show the release version - #32

Open
rodchristiansen wants to merge 1 commit into
mainfrom
fix/polish
Open

rodchristiansen wants to merge 1 commit into
mainfrom
fix/polish

Conversation

@rodchristiansen

Copy link
Copy Markdown
Contributor

Three fixes from verifying v2026.10.06.2019.

Simulation wording and duplicates

  • A simulation logged "4 user(s) removed" and "Removed 1 orphaned recycle bin(s)" though it removes nothing. Those lines, and the per-user scheduled task count, now say "would remove" when simulating.
  • An enabled local account with no profile was evaluated by the main pass and again by the orphan pass, so a simulation listed it twice. The main pass now evaluates only accounts with a profile. A profile-less account is left to the orphan pass, which dates it by password age; the main pass had no profile folder to date it by and used the current time.

Deleting an account with no profile

  • DeleteProfileW was called even when the account had no ProfileList entry. It failed with error 2 and logged a warning before falling back. It is now skipped when there is no profile. The fallback only logs a registry entry as deleted when one existed.

App version

  • The Managed Users Cleanup Prefs header showed the build time. It now shows the informational version stamped from the tag, zero-padded, with the +<commit> suffix dropped, e.g. 2026.10.06.2019.

Tests: new RunReportingTests cover the wording, the de-duplication, the DeleteProfileW guard and the version text. All 86 tests pass locally.

… and show the release version

A simulation logged 'user(s) removed' and 'Removed N orphaned recycle bin(s)' though it removes nothing; it now says 'would remove', as do the per-user task counts. An enabled account with no profile was evaluated by both the main pass and the orphan pass, so a simulation listed it twice; the orphan pass, which dates it by password age, now owns it. Deleting an account that never had a profile no longer calls DeleteProfileW and logs its failure. The app's Prefs header shows the version stamped from the release tag instead of the build time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant