Repository navigation
Report simulations as what they would remove, list each account once, and show the release version - #32
Open
rodchristiansen wants to merge 1 commit into
Open
Report simulations as what they would remove, list each account once, and show the release version#32rodchristiansen wants to merge 1 commit into
rodchristiansen wants to merge 1 commit into
Conversation
… and show the release version A simulation logged 'user(s) removed' and 'Removed N orphaned recycle bin(s)' though it removes nothing; it now says 'would remove', as do the per-user task counts. An enabled account with no profile was evaluated by both the main pass and the orphan pass, so a simulation listed it twice; the orphan pass, which dates it by password age, now owns it. Deleting an account that never had a profile no longer calls DeleteProfileW and logs its failure. The app's Prefs header shows the version stamped from the release tag instead of the build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from verifying v2026.10.06.2019.
Simulation wording and duplicates
Deleting an account with no profile
App version
+<commit>suffix dropped, e.g. 2026.10.06.2019.Tests: new
RunReportingTestscover the wording, the de-duplication, the DeleteProfileW guard and the version text. All 86 tests pass locally.