Repository navigation
Update Analyzer and ensure latest differences data. - #2999
hermitdave wants to merge 10 commits into
Conversation
Updating Analyzer for latest SDK versions Remove Differences for API Contract 6.0.0.0 Add Differences for API Contract 8.0.0.0
|
Thanks @hermitdave is the analyzer only able to look at N-1? Could we have it keep the old differences in order to alert folks of what min they need to target as we'll still be supporting down to 16299 for now? Also looks like the CI build is failing |
|
The N-2 logic is hard code though I can take a look at making it flexible. |
|
Thanks @hermitdave, let us know if you want to chat and bounce ideas off. I'm not entirely familiar with how this works, but I remember there was a problem where we didn't know what the min version the application is targeting? If so, could we use this type of analyzer example to grab info from parsing the csproj manually? |
|
There is no info on how analyzer can read csproj / vbproj files. Info requested from VS / SDK tab fell on deaf ears. The original analyzer code that this is roughly based on added dummy file reference when nuget script was run during initial reference and I want comfortable with that mechanism. When project target SDK version is updated, IMO the dummy file wouldn't be updated and old SDK versions will continue to be used by analyzer making it useless. I personally do not know of any way. |
Simplify nesting for checks
|
@michael-hawker I have added support for 16299 and onwards and simplified the logic. I cannot fully the code changes as I cannot compile the toolkit for a long time now having tried both VS 2017 and VS 2019. |
| @@ -29,27 +29,38 @@ internal enum TypePresenceIndicator | |||
| /// <summary> | |||
| /// Embedded differences between API contract version 4 and 5. | |||
There was a problem hiding this comment.
Just missing a comment update here:
| /// Embedded differences between API contract version 4 and 5. | |
| /// Embedded differences between API contract version 5 and 6. |
5 was 16299, eh?
|
@hermitdave sorry about that, if you've rebased on top of the latest master, you just need to run |
azchohfi
left a comment
There was a problem hiding this comment.
It was throwing exceptions on the analyzer for me. There seems to be a missing:
_differencesDictionary.Add(N2DifferencesRes, GetApiAdditions(N2DifferencesRes));at line 93.
After adding that a simple file new UWP project triggers maaaany false positives, for v1 APIs. It's pretty much tagging everything now.
|
@hermitdave did you see @azchohfi comment? Have you been able to verify this and find a solution? Thanks! |
|
@michael-hawker i can't seem to be compile any xaml uwp projects on Surface book. I will try again on a different device but that requires dev setup. As for false positives, the code is dumb - it flags anything that is in changes in the versions supported. |
|
@azchohfi @hermitdave realizing now that once we move to WinUI 3, it's going to support all its versions, so there's just a single API surface. Since we're having trouble getting these to work properly, does it instead make sense just to deprecate them and move on? As once we adopt WinUI 3, by construction, it basically solves these types of issues? Thoughts? |
|
WinUI3 will be RS4+, but this is only for WUX APIs, not everything. This package checks for every WinRT API, not only WUX. I think it still makes sense. |
|
@hermitdave @azchohfi did they recently add helpers to VS? |
|
No idea. |
|
@hermitdave since we don't have a good way to know the target of the project and have to continually update diffs but flag everything, should we just work with the VS team to get this added to VS like the XAML analyzers and just drop support for it in the Toolkit? |
|
@LyalinDotCom we've been at a bit of an impasse here, do you know how the analyzer I saw above works and who owns it? This is a recently added feature, eh? It'd be great to know what's going on in this space, so if anything we just deprecate our attempts here, remove it from the Toolkit, and leverage/contribute to VS efforts instead? Thanks! |
|
@michael-hawker I'll respond over teams |
|
Forgot we had this discussion already just elsewhere, looping back and closing this issue based on comment from here. |

Updating Analyzer for latest SDK versions
Remove Differences for API Contract 6.0.0.0
Add Differences for API Contract 8.0.0.0
Issue: #
mrlacey/Rapid-XAML-Toolkit#146 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Older SDKs being referenced
What is the new behavior?
Update SDKs being referenced
PR Checklist
Please check if your PR fulfills the following requirements:
Other information