fix: address the accessibility audit's first real findings - #17
Merged
Merged
Conversation
This is the audit's first run against the app, and it found genuine defects rather than noise. The empty-reminders "Create a Task" button and the weather-unavailable "Try Again" button both used plain .buttonStyle(.glass). Plain glass renders translucent over whatever content sits behind it, so its contrast is unpredictable rather than guaranteed, which is exactly what the audit caught on both. Both are primary calls to action, so switched to .glassProminent, which is what Apple recommends for exactly this case and computes a readable foreground against its tint automatically. SettingsIconLabel's icon used a fixed 29pt frame that never grew with Dynamic Type, so at large text sizes the icon shrank relative to the surrounding row text. Replaced the fixed size with @ScaledMetric so it scales with the same setting the text does. This component backs most rows in Settings, so the fix applies broadly from one change. The remaining findings (several Settings section headers and the location permission button) trace back to the app's custom accent color, whose luminance is too close to its background for WCAG text contrast. That is a brand color decision, not a bug, and is deferred to a follow-up with real design options rather than changed here silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accessibility audit added in #15 ran for the first time and found real defects on three of the four screens it covers.
Two buttons had unpredictable contrast. The empty-reminders "Create a Task" button and the weather-unavailable "Try Again" button both used plain
.buttonStyle(.glass). Plain glass renders translucent over whatever content sits behind it, so its contrast depends on that content rather than being guaranteed. Both buttons are primary calls to action, so switched to.glassProminent, which Apple recommends for exactly this case and which computes a readable foreground against its own tint.An icon didn't scale with Dynamic Type.
SettingsIconLabel's icon used a fixed 29pt frame, so at large text sizes the icon shrank relative to the row's growing text. That component backs most rows in Settings, so replacing the fixed size with@ScaledMetricfixes it across the whole screen from one change.What's deferred, and why. The remaining findings (several Settings section headers, the location permission button) trace back to the app's custom accent color. A rough contrast check puts its luminance around 2.85:1 against a light background for text use, below WCAG's 4.5:1 threshold for normal text. That's a brand color decision, not a bug, so it needs real design options and screenshots rather than a silent change here. Tracked locally, and it does not block submission since Apple's review doesn't gate on this audit.