chore: set iOS/watchOS deployment target to 26.0 (iOS down, watchOS up) - #2
Merged
Merged
Conversation
Wes corrected the platform floor to 26.0 everywhere (not 27.0 as
originally planned 2026-09-25). This lands both directions at 26.0:
iOS 26.4 -> 26.0 (decrease) and watchOS 11.5 -> 26.0 (large increase).
RHOIDSShared's Package.swift also moves .iOS(.v18) -> .iOS("26.0");
it isn't linked by any watchOS target so no .watchOS platform entry
was added.
project.yml edited, regenerated with the pinned XcodeGen 2.45.4.
Diff is target-lines-only. Clean build on generic/iOS Simulator
(RHOIDS scheme) and generic/watchOS (RHOIDSWatch target); no watchOS
27 runtime installed locally so device/simulator tests aren't
possible here.
Follow-up: dead-code recheck against the new 26.0 floor (not 27.0):
- Sources/RHOIDS/Models/AlarmSound.swift:144 (iOS 15.2) - dead.
- Sources/RHOIDSShieldConfiguration/FocusLockShieldConfig.swift:49,56
and Sources/RHOIDSShieldAction/FocusLockShieldAction.swift:31
(iOS 26.5) - still above the 26.0 floor, not dead.
- Sources/Shared/AlarmKitService.swift:99 (iOS 26.1) - NOT dead at a
26.0 floor (26.1 > 26.0); the plan doc listed this as dead, which
looks like an error - flagging for Darrow rather than silently
correcting the plan.
None of these guards were touched in this pass.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The prior commit (0fdbc92) updated the per-target settings.base overrides to 26.0 but missed project.yml's top-level `deploymentTarget` key (iOS 26.4, watchOS 11.5), which XcodeGen also uses for the project's default build configuration. That left a stray WATCHOS_DEPLOYMENT_TARGET = 11.5 in the generated pbxproj even though every target-level config was already correct. Regenerated with the pinned XcodeGen 2.45.4; diff is target-lines-only, no other keys touched. Verified no remaining 11.5/26.4 in the pbxproj. Clean build: RHOIDS scheme on generic/iOS Simulator, RHOIDSWatch target on generic/watchOS Simulator (no watchOS 27 runtime installed locally, so no on-device/simulator run). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
weskcode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settings.baseoverrides but missedproject.yml's top-leveldeploymentTargetkey and a few remaining per-target overrides, which XcodeGen also uses for the project's default build configuration. Regenerated with the pinned XcodeGen version.Sources/RHOIDSShared/Package.swift):.iOS(.v18)→.iOS("26.0")main: 3 files (project.yml,RHOIDS.xcodeproj/project.pbxproj,Sources/RHOIDSShared/Package.swift), target-lines-only.Sources/RHOIDS/Models/AlarmSound.swift:144—#available(iOS 15.2, *)is now always-true under the 26.0 floor. Still-live guards left alone:AlarmKitService.swift:99(iOS 26.1),FocusLockShieldConfig.swift:49/56,FocusLockShieldAction.swift:31(iOS 26.5) — all above the new floor.Test plan
xcodebuild -project RHOIDS.xcodeproj -scheme RHOIDS -destination 'platform=iOS Simulator,name=iPhone 18 Pro,OS=27.0' test— TEST SUCCEEDED, 752/752 passed, 71 suites, 29.383s.xcodebuild -project RHOIDS.xcodeproj -scheme RHOIDSWatchTests -destination 'generic/platform=watchOS' build(no sharedRHOIDSWatchapp scheme exists, so used the shared test scheme covering it) — BUILD SUCCEEDED. Watch tests stay on Xcode Cloud, not run locally here.~/Developer/bot-memory/ios27-logs/rhoids.log.🤖 Generated with Claude Code