Repository navigation
Should not catch all exceptions #21
Description
Line 65 in 660a5ae
In the event of some other errors, the exception is just swallowed. For example, a network error. You should list the exceptions that you want to catch.
And I think the code expects that an exception will be raised if the status code is 4xx/5xx, but, as far as I know, it's not the case.
Activity
ellardli commentedon May 13, 2015
Got it. I'll check out the types of exceptions that the block can throw and expand the handler to handle them properly.