Skip to content

release.yml wrapper lockstep reads stale packages/<pkg> path after #404 reorg #418

Description

@vivek7405

Problem

The auto-release workflow's wrapper lockstep step (.github/workflows/release.yml, the Lockstep-publish wrappers step) bumps create-webjs + webjsdev to match @webjsdev/cli before publishing. It reads the manifest with a hard-coded path:

const path = './packages/${pkg}/package.json';

PR #404 moved both wrappers to packages/wrappers/, so ./packages/create-webjs/package.json no longer exists. The node -e would throw ENOENT and fail the wrapper publish.

Latent, not yet fired: the npm publish --workspace=${pkg} calls are name-based (dir-move-safe), and the last CLI release (#380, wrappers at 0.10.12) predates #404, so the broken path has not been exercised. The NEXT @webjsdev/cli release would fail the lockstep.

Same class as #409 (the Dockerfile stale packages/ts-plugin path): #404 updated most path tooling but missed this workflow line.

Fix

  • Repoint the lockstep manifest path to ./packages/wrappers/${pkg}/package.json.
  • Add a repo-health guard asserting the wrapper manifests referenced by the release workflow exist (so a future move fails CI, not the next release).

Acceptance criteria

  • release.yml lockstep reads the correct packages/wrappers/<pkg> path.
  • A guard test catches a stale wrapper path.
  • Verified the wrappers still publish in lockstep with cli (name-based publish + correct version bump).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions