-
Notifications
You must be signed in to change notification settings - Fork 70
fix(bundling): fixed the multiple React instance and useRef errors #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
480aed9
9408855
853f380
21125c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,9 @@ const StationLogin: React.FunctionComponent<StationLoginProps> = observer(({onLo | |
| const {cc, teams, loginOptions} = store; | ||
| const result = useStationLogin({cc, onLogin, onLogout}); | ||
|
|
||
| console.log('StationLogin: Teams >>', teams); | ||
| console.log('StationLogin: Login Options >>', loginOptions); | ||
|
Comment on lines
+13
to
+14
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need these console statements anymore?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will remove
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in the PR - #356 |
||
|
|
||
| const props = { | ||
| ...result, | ||
| teams, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| .box { | ||
| background-color: #ffffff; | ||
| border-radius: 8px; | ||
| box-shadow: 0 2px 4px rgba(0, 0, 0, 0.1); | ||
| padding: 20px; | ||
| max-width: 800px; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .section-box { | ||
| padding: 10px; | ||
| border: 1px solid #ddd; | ||
| border-radius: 8px; | ||
| } | ||
|
|
||
| .fieldset { | ||
| border: 1px solid #ccc; | ||
| border-radius: 5px; | ||
| padding: 10px; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| .legend-box { | ||
| font-weight: bold; | ||
| color: #0052bf; | ||
| } | ||
|
|
||
| .btn { | ||
| padding: 10px 20px; | ||
| background-color: #0052bf; | ||
| color: white; | ||
| border: none; | ||
| border-radius: 4px; | ||
| cursor: pointer; | ||
| transition: background-color 0.3s; | ||
| margin-right: 8px; | ||
| } | ||
|
|
||
| .select { | ||
| width: 100%; | ||
| padding: 8px; | ||
| margin-top: 8px; | ||
| margin-bottom: 12px; | ||
| border: 1px solid #ccc; | ||
| border-radius: 4px; | ||
| } | ||
|
|
||
| .input { | ||
| width: 97%; | ||
| padding: 8px; | ||
| margin-top: 8px; | ||
| margin-bottom: 12px; | ||
| border: 1px solid #ccc; | ||
| border-radius: 4px; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider calling clean in individual widgets instead of the global
package.jsoncommand?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are at individual package level, we run all of them once with
workspaces foreach ...command. Correct me if I misunderstoodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in the PR - #356