Skip to content

feat(recording): add zoom marker shortcut - #353

Closed
meiiie wants to merge 1 commit into
webadderallorg:mainfrom
the-wiii-lab:feat/recording-zoom-shortcut
Closed

meiiie wants to merge 1 commit into
webadderallorg:mainfrom
the-wiii-lab:feat/recording-zoom-shortcut

Conversation

@meiiie

@meiiie meiiie commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Add a recording-time shortcut so pressing CommandOrControl+Alt+Z while recording creates a manual zoom marker that is converted into a zoom region when the new recording opens in the editor.

Motivation

Issue #352 asks for a keyboard shortcut during recording to add a zoom. Recordly already writes cursor telemetry while recording and builds editor zoom regions from recording metadata, so this keeps the implementation narrow by storing an explicit manual-zoom marker in the existing telemetry sidecar instead of adding a new project format or settings surface.

Type of Change

  • Bug Fix
  • New Feature
  • Refactor / Code Cleanup
  • Documentation Update
  • Other (please specify)

Related Issue(s)

Changes Made

  • register CommandOrControl+Alt+Z only while an active recording is running
  • store shortcut presses as manual-zoom cursor telemetry markers with the current cursor focus
  • convert manual markers from fresh recordings into manual zoom regions in the editor
  • keep manual zoom markers out of automatic zoom suggestion and cursor click-effect paths
  • add focused unit coverage for marker-to-region placement behavior

Testing Guide

  1. Start a screen recording.
  2. Press CommandOrControl+Alt+Z at moments where a zoom should be added.
  3. Stop recording and open the editor.
  4. Verify manual zoom regions appear at those timestamps and focus around the cursor position.
  5. Verify recordings without manual markers keep the existing auto-zoom suggestion behavior.

Checklist

  • I have performed a self-review of my code.
  • I have tested the changes locally.
  • I have added focused regression coverage for the new behavior.
  • I have completed a manual recording runtime smoke test.
  • I have linked screenshots or videos where helpful.

Local checks run:

  • vitest run src/components/video-editor/timeline/recordingZoomMarkers.test.ts
  • tsc --noEmit
  • biome check src/components/video-editor/timeline/recordingZoomMarkers.ts src/components/video-editor/timeline/recordingZoomMarkers.test.ts
  • biome check --formatter-enabled=false src/components/video-editor/timeline/recordingZoomMarkers.ts src/components/video-editor/timeline/recordingZoomMarkers.test.ts electron/ipc/cursor/telemetry.ts electron/main.ts

Notes:

  • The shortcut is intentionally fixed to CommandOrControl+Alt+Z for this first pass. If you prefer a different accelerator or a configurable shortcut, I can adjust in a follow-up without expanding this PR into a settings change.
  • Keeping this as draft until the shortcut is verified in a real recording session.

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 53806ac0-fc21-4d6b-af4b-50dae0c29694

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@meiiie

meiiie commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this draft to keep the queue clean for the v1.3.0 beta cycle. The recording zoom shortcut should come back only as a fresh PR from current main after a real recording-session smoke confirms the shortcut behavior end to end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant