Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing this draft to keep the queue clean for the v1.3.0 beta cycle. The recording zoom shortcut should come back only as a fresh PR from current main after a real recording-session smoke confirms the shortcut behavior end to end. |
Description
Add a recording-time shortcut so pressing
CommandOrControl+Alt+Zwhile recording creates a manual zoom marker that is converted into a zoom region when the new recording opens in the editor.Motivation
Issue #352 asks for a keyboard shortcut during recording to add a zoom. Recordly already writes cursor telemetry while recording and builds editor zoom regions from recording metadata, so this keeps the implementation narrow by storing an explicit
manual-zoommarker in the existing telemetry sidecar instead of adding a new project format or settings surface.Type of Change
Related Issue(s)
Changes Made
CommandOrControl+Alt+Zonly while an active recording is runningmanual-zoomcursor telemetry markers with the current cursor focusTesting Guide
CommandOrControl+Alt+Zat moments where a zoom should be added.Checklist
Local checks run:
vitest run src/components/video-editor/timeline/recordingZoomMarkers.test.tstsc --noEmitbiome check src/components/video-editor/timeline/recordingZoomMarkers.ts src/components/video-editor/timeline/recordingZoomMarkers.test.tsbiome check --formatter-enabled=false src/components/video-editor/timeline/recordingZoomMarkers.ts src/components/video-editor/timeline/recordingZoomMarkers.test.ts electron/ipc/cursor/telemetry.ts electron/main.tsNotes:
CommandOrControl+Alt+Zfor this first pass. If you prefer a different accelerator or a configurable shortcut, I can adjust in a follow-up without expanding this PR into a settings change.