Repository navigation
fix(config): ignore non-mapping veADK YAML roots - #191
Open
cangen185-sudo wants to merge 1 commit into
Open
cangen185-sudo wants to merge 1 commit into
cangen185-sudo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An existing
config.yamlcontaining a YAML list, string, boolean, or number can abort runtime environment assembly withAttributeErrorinflatten_dict(). For example,- itemreaches.items()even though the compatibility loader expects a mapping.Validate the root before flattening and follow the loader's existing warning-and-skip behavior for invalid configuration. Other environment sources continue to merge normally. Valid mappings and environment precedence are unchanged.
Validation
python -m pytest tests/toolkit/config tests/client/test_base_service_client_errors.py tests/client/test_tools_mcp_types.py tests/client/test_tools_tos_mount_types.py tests/utils -q..env, common, and strategy values.git diff --checkpassed.Prepared with Codex assistance. A separate read-only review checked the root cause and final diff. No dependencies or generated files changed.