Skip to content

--filter no-match should not fail by default; add --fail-if-no-match for strict mode #380

Description

@wan9chi

vp run --filter {.}^... build fails when the filter matches no packages (e.g. a leaf package with no workspace deps). For traversal filters that exclude the seed, zero matches is a legitimate outcome, not a typo.

We should match pnpm's behavior: treat no-match as success by default, and add --fail-if-no-match for callers (CI, scripts) that want strict behavior.

For reference, pnpm exits 0 on no-match and supports --fail-if-no-match (and a failIfNoMatch setting) to opt into failure: https://pnpm.io/filtering

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions