fix(create): remove nested monorepo lint config - #2667
Merged
fengmk2 merged 4 commits intoSep 17, 2026
Merged
Conversation
Member
|
Can you add a new snapshot test case to cover this bug fix? |
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
semimikoh
force-pushed
the
fix/create-monorepo-lint-config
branch
from
September 11, 2026 08:08
dd80e94 to
e988fd6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd80e94f48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
semimikoh
force-pushed
the
fix/create-monorepo-lint-config
branch
from
September 11, 2026 09:12
e988fd6 to
9932a48
Compare
Contributor
Author
|
@fengmk2 I added snapshot test coverage for this bug fix. Thanks for the suggestion! |
fengmk2
added
test: e2e
Member
|
@semimikoh According to the description at #2668, the lint and fmt configurations do not support nested configurations, so we need to further process the |
The standalone library template enables lint type checking, but nested lint configuration is not supported in monorepos. Remove the generated library's lint block during monorepo scaffolding while preserving it for standalone libraries. Apply the cleanup when adding libraries to existing monorepos as well. Use an AST-based config-key transform restricted to direct config objects, and add CLI snapshot coverage for both creation paths.
Remove unsupported lint and fmt configuration from libraries created inside monorepos while preserving both for standalone library projects. Update unit and CLI snapshot coverage for initial monorepo creation and libraries added to existing monorepos.
semimikoh
force-pushed
the
fix/create-monorepo-lint-config
branch
from
September 14, 2026 01:58
9932a48 to
2722bae
Compare
Contributor
Author
fengmk2
approved these changes
Sep 17, 2026
fengmk2
added a commit
that referenced
this pull request
Sep 18, 2026
This release fixes Homebrew setup, Windows installation, and workspace dependency commands. It also updates Rolldown, Oxlint, and Oxfmt. ### Fixes & Enhancements - Homebrew installations complete setup once, retain their bundled CLI, and direct upgrades to `brew upgrade vite-plus` ([#2729](#2729)), by @fengmk2. - Windows installations decode remote legacy PowerShell scripts correctly ([#2701](#2701)), by @james-elicx. - `vp migrate` removes the unsupported React Refresh `allowCompoundComponents` option and warns about possible lint errors ([#2702](#2702)), by @fengmk2. - New monorepo packages use the root lint configuration without a conflicting nested configuration ([#2667](#2667)), by @semimikoh. - Yarn Classic rejects filtered additions and removals instead of changing unintended dependencies ([#2705](#2705)), by @jong-kyung. - Yarn Berry rejects unsupported filtered updates and respects filters during recursive removal ([#2709](#2709), [#2712](#2712)), by @jong-kyung. - Yarn and Bun warn when a command does not support `--workspace-root`. Yarn Classic accepts root additions through `vp add` and `vp install <packages>` ([#2713](#2713)), by @jong-kyung. - `vp dedupe` warns about unsupported check options ([#2717](#2717)), by @jong-kyung. - Rust command output respects `NO_COLOR` ([#2716](#2716)), by @liangmiQwQ. - Windows commands find lowercase shims in directories with case-sensitive file names ([#2727](#2727)), by @fengmk2. ### Dependency Updates - Update `rolldown@1.2.8` to `rolldown@1.2.9`, `oxlint@1.82.0` to `oxlint@1.83.0`, and `oxfmt@0.67.0` to `oxfmt@0.68.0`. The new lint and format versions can flag code that passed before. Run `vp fmt` after upgrading if CI runs `vp check` ([#2725](#2725)), by @voidzero-guard[bot]. ### Docs - Reorganize the guide and expand the global CLI sections ([#2684](#2684), [#2715](#2715)), by @liangmiQwQ. - Explain Nushell startup requirements and recovery for XDG installations ([#2704](#2704)), by @naokihaba. ### Chore - Add documentation previews for fork PRs ([#2691](#2691)), by @fengmk2. - Publish `@voidzero-dev/vite-plus-prompts` with npm releases ([#2707](#2707)), by @fengmk2. - Reuse native preview installations and clarify release evidence and package checks ([#2693](#2693), [#2708](#2708)), by @fengmk2. - Stabilize dependency-removal snapshots and temporarily skip Socket Firewall tests on Windows ([#2711](#2711), [#2730](#2730)), by @fengmk2. - Clarify package-manager comments and update the preview workflow reference ([#2706](#2706), [#2714](#2714)), by @jong-kyung. - Run dependency upgrade automation with Kimi K3 ([#2723](#2723)), by @Brooooooklyn. ### Bundled Versions | Tool | Version | Source | | --- | --- | --- | | `vite` | `8.3.0` | [`434e8e9`](vitejs/vite@434e8e9) | | `rolldown` | `1.2.9` | [`5b4746e`](rolldown/rolldown@5b4746e) | | `tsdown` | `0.23.0` | [npm](https://npmx.dev/package/tsdown/v/0.23.0) | | `vitest` | `4.1.11` | [npm](https://npmx.dev/package/vitest/v/4.1.11) | | `oxlint` | `1.83.0` | [npm](https://npmx.dev/package/oxlint/v/1.83.0) | | `oxlint-tsgolint` | `7.0.2001` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/7.0.2001) | | `oxfmt` | `0.68.0` | [npm](https://npmx.dev/package/oxfmt/v/0.68.0) | ### Upgrade ```bash vp upgrade ``` ### New Contributors @james-elicx **Full Changelog**: v0.3.2...v0.3.3 --- Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK <fengmk2@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vite:libraryprojectsFixes #2640