cegui: drop unused dependencies in makedepends; SMC/cegui07: remove - #38614
Merged
Conversation
Member
|
re: the conflict found in CI, might be good to deal with cegui07's python in this PR too btw: thanks for taking care of these! |
Member
|
hm, the only thing using cegui07 is what TSC is forked from, which hasn't had a commit in 8 years |
TinfoilSubmarine
changed the title
paper42
reviewed
Aug 11, 2022
TinfoilSubmarine
force-pushed
the
update/cegui
branch
3 times, most recently
from
August 12, 2022 14:32
8bec68c to
f90f229
Compare
Member
|
re: conflict I'm inclined to say that SMC and cegui07 should be removed. SMC was added in 2015 and hasn't had an update since 2009. Its fork, TSC, has more active development (latest release 2020). |
paper42
reviewed
Aug 12, 2022
doesn't work with latest upstream version of dependencies, fork `TSC` is in void-packages already and has more recent updates
TinfoilSubmarine
force-pushed
the
update/cegui
branch
from
August 15, 2022 12:39
f90f229 to
48d4676
Compare
TinfoilSubmarine
changed the title
it was only used for SMC, which was already removed
The only package currently depending on cegui (TSC) doesn't require these and they are both EOL: - Drop python-devel, since configure output shows that it wasn't even building the python extension modules due to some issue with Boost-python. - Drop gtk2 (gtk+-devel) since it is only used for samples, and TSC only required freetype2, which is now included separately instead of pulled in in dependency tree of gtk+-devel.
TinfoilSubmarine
force-pushed
the
update/cegui
branch
from
August 15, 2022 12:42
48d4676 to
4ea2a00
Compare
classabbyamp
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
TSCwith updatedgecui)Another one not actually using
python-devel. Configure output shows that it wasn't even building the python extension modules due to some issue with Boost-python. The only package depending on this isTSCand it doesn't seem to require the python extensions.