Repository navigation
Move to SvelteKit 3 - #43
Merged
Merged
Conversation
…$app/tsconfig SvelteKit 3 needs Node 22.17 or later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tests resolve #lib through package.json too, so they no longer need an alias of their own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SvelteKit 3 deprecates its json() helper and folds goto's noScroll and keepFocus into reset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…em through SvelteKit 3 refuses a POST or DELETE with no content type whose Origin isn't its own, and adapter-node takes the server to be https, so deleting a review, stopping a generation or agent review, removing a persona, reviewer or provider, and resetting or running Stats' analysis were all refused once built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tsconfig now extends $app/tsconfig, which only exists once SvelteKit has synced, and npm skips the prepare script where scripts are turned off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vivecuervo7
commented
Nov 7, 2026
vivecuervo7
left a comment
Owner
Author
There was a problem hiding this comment.
[Low] The PR body says the ParamMatcher type moved to @sveltejs/kit/params, but the matcher was replaced.
web/src/params.ts uses defineParams and imports no ParamMatcher; src/params/round.ts is deleted. The description should say the matcher was rewritten with defineParams.
Owner
Author
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves Docent to SvelteKit 3.1 and adapter-node 6.
$libimports become#lib/….jssubpath imports declared inpackage.json, since Kit 3 no longer generates the alias. The tests now resolve them the same way, sovitest.config.tsloses its own alias.src/params/round.tsto a singlesrc/params.tsusingdefineParams.Handletype comes from its new@sveltejs/kit/hooksentry point.json()becomesResponse.json()in every route,hooks.server.tsand/mcp, as Kit 3 deprecates the helper.ThreadTriage'sgotousesreplaceandreset: falsein place ofreplaceState,noScrollandkeepFocus.sendWithoutBody), since Kit 3's CSRF check refuses them otherwise once built: adapter-node takes the server to be https, so the page's http Origin never matches.npm testsyncs SvelteKit first, as the tsconfig now extends the generated$app/tsconfig.tsconfig.jsonextends$app/tsconfig; Node 22.17 or later is required.Why
The first step of the SvelteKit idiom pass: everything after it (remote functions, hooks, error boundaries) is written against Kit 3, so it's done once rather than twice.
How
The official
sv migrate sveltekit-3tasks were run one at a time, one commit each, so each step can be reviewed on its own; the tool's manual-task list was then worked through by hand.Checked on this branch: a fresh
npm ciwith npm scripts off followed bynpm test(54 passing),npm run check, a production build served with a copy of the data,vite dev, the start page, a four-round PR's tabs and round switch, a slice, Settings, Stats and Getting started in a browser, a?thread=deep link, and/mcp(initialize, tools/list, foreign-Host 403). Bodiless changes were checked against a production build from a browser.🤖 Generated with Claude Code