feat(obd_ai): add foundation layer and approved command catalog - #10
virtuscyber wants to merge 1 commit into
Conversation
🤖 Augment PR SummarySummary: This PR introduces a new Changes:
Technical Notes: The catalog is enforced via key-based lookups and uses 🤖 Was this summary useful? React with 👍 or 👎 |
| assert "stored_trouble_codes" in catalog | ||
| assert "pending_trouble_codes" in catalog | ||
| assert "clear_trouble_codes" not in catalog | ||
| assert "CLEAR_DTC" not in catalog |
There was a problem hiding this comment.
tests/test_obd_ai_catalog.py:23 — "CLEAR_DTC" not in catalog is checking membership by approved key, but ApprovedCommandCatalog.__contains__ only looks at approved keys (e.g., clear_trouble_codes), not OBD command names. As written, this assertion doesn’t actually validate that the write command is excluded and may give a false sense of safety coverage.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Refs #1
This opens the foundation lane for the LLM-safe OBD diagnostics stack.
Includes:
Stack order: #1 -> #2 -> #3 -> #4 -> #5