You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this supposed to be opposite of what lodash range function does? Naming it range might create a confusion i think, as the function intends to do is find the maximum difference. How about maxDifference() or something on that line?
ahhh yes, good point. And it brings up a lot of other good points. I guess it depends on any given user's familiarity with lodash, and whether we consider namespacing as significant enough differentiation. Within the context of statistics, range is definitely the correct term to use, so I wouldn't be quick to give lodash a monopoly on the term just because its one of the most popular libraries out there (especially since this library is mostly for edifying purposes). But for clarity's sake, we might consider prefixing any arithmetic/statistical method with get (for example, getRange() or getAverage()). another option might be further namespacing like variadic.stats.range().
So I've never really been involved in something like this before, but I guess the collaborators of the repo would need to do some planning ahead to figure out what categories of functions they expect to have and decide on a namespacing conventions ahead of time. Or else, just move forward and introduce namespaces as needed. Of course the latter would mean making breaking changes every time you introduce a new namespace
@someyoungideas actually someone just submitted a pull request for this one. If you look in the readme there are some other opportunities that might interest you. If you find one just create an issue for it.
Activity
khusbuchandra commentedon Jan 27, 2018
Is this supposed to be opposite of what lodash range function does? Naming it range might create a confusion i think, as the function intends to do is find the maximum difference. How about maxDifference() or something on that line?
jmbothe commentedon Jan 27, 2018
ahhh yes, good point. And it brings up a lot of other good points. I guess it depends on any given user's familiarity with lodash, and whether we consider namespacing as significant enough differentiation. Within the context of statistics,
rangeis definitely the correct term to use, so I wouldn't be quick to give lodash a monopoly on the term just because its one of the most popular libraries out there (especially since this library is mostly for edifying purposes). But for clarity's sake, we might consider prefixing any arithmetic/statistical method withget(for example,getRange()orgetAverage()). another option might be further namespacing likevariadic.stats.range().just spitballing right now. thoughts?
khusbuchandra commentedon Jan 28, 2018
Now I understand where you are coming from and agree to it. I like the idea of namespacing, lets have a standard and have it across.
jhowardjr commentedon Jan 28, 2018
👍namespacing would be the cleaner implementation.
jmbothe commentedon Jan 28, 2018
So I've never really been involved in something like this before, but I guess the collaborators of the repo would need to do some planning ahead to figure out what categories of functions they expect to have and decide on a namespacing conventions ahead of time. Or else, just move forward and introduce namespaces as needed. Of course the latter would mean making breaking changes every time you introduce a new namespace
someyoungideas commentedon Mar 10, 2018
I'd be glad to take this item if it is still available.
jhowardjr commentedon Mar 10, 2018
@someyoungideas actually someone just submitted a pull request for this one. If you look in the readme there are some other opportunities that might interest you. If you find one just create an issue for it.