Skip to content

[json_parser] Add missing isolate scope - #214

Merged
isheludko merged 1 commit into
v8:node-ci-2025-03-10from
backes:add-missing-isolate-scope
Apr 16, 2025
Merged

[json_parser] Add missing isolate scope#214
isheludko merged 1 commit into
v8:node-ci-2025-03-10from
backes:add-missing-isolate-scope

Conversation

@backes

@backes backes commented Apr 16, 2025

Copy link
Copy Markdown
Member

Other methods in the same file already had it, but in this one spot it was missing. This blocked https://crrev.com/c/6458560.

Other methods in the same file already had it, but in this one spot it
was missing. This blocked https://crrev.com/c/6458560.
@isheludko
isheludko self-requested a review April 16, 2025 15:06

@isheludko isheludko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isheludko
isheludko merged commit 77cb4a4 into v8:node-ci-2025-03-10 Apr 16, 2025
@backes
backes deleted the add-missing-isolate-scope branch April 17, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants