Bump MSRV to 1.54.0 - #2869
Merged
Merged
Conversation
tertsdiepraam
force-pushed
the
rust-1.54
branch
from
January 15, 2022 11:09
394f028 to
df92772
Compare
Collaborator
Author
|
The fixed clippy lints are new in version |
Contributor
|
Let's release a version before merging this...
…On Sat, Jan 15, 2022, 04:21 Terts Diepraam ***@***.***> wrote:
Drivers:
- clap 3 only supports 1.54 and up.
- Const generics MVP
- Arrays implement IntoIterator
- Or patterns
- Many standard library stabilizations
It might be worth noting that this is ahead of Debian Bullseye's version
of Rust (1.48). I left out improvements that could be made with this new
Rust version to keep this PR simple.
------------------------------
You can view, comment on, or merge this pull request online at:
#2869
Commit Summary
- 783170c
<783170c>
change msrv to 1.54
File Changes
(3 files <https://github.com/uutils/coreutils/pull/2869/files>)
- *M* .github/workflows/CICD.yml
<https://github.com/uutils/coreutils/pull/2869/files#diff-fdc42f85e64d73f2d88830f87cfb3c6f32c93a440ed1aaaf6bfbcb8648fb9def>
(2)
- *M* Cargo.lock
<https://github.com/uutils/coreutils/pull/2869/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e>
(51)
- *M* README.md
<https://github.com/uutils/coreutils/pull/2869/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(2)
Patch Links:
- https://github.com/uutils/coreutils/pull/2869.patch
- https://github.com/uutils/coreutils/pull/2869.diff
—
Reply to this email directly, view it on GitHub
<#2869>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATSBD7ZEAJ4DVDFRPQBR3UWFDBHANCNFSM5MA2KDXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
|
Good idea!
Le 15/01/2022 à 15:34, Roy Ivy III a écrit :
Let's release a version before merging this...
Sylvestre
… Message ID: ***@***.***>
|
Collaborator
Author
|
Yeah, that's a good idea |
tertsdiepraam
force-pushed
the
rust-1.54
branch
from
January 16, 2022 09:31
df92772 to
783170c
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drivers:
clap3 only supports 1.54 and up.IntoIteratorIt might be worth noting that this is ahead of Debian Bullseye's version of Rust (1.48). I left out improvements that could be made with this new Rust version to keep this PR simple.