feat(web): add optional memo quick action buttons#6086
Open
RitheshKumar26 wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughChangesMemo quick actions
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/src/components/MemoView/components/MemoQuickActions.tsx`:
- Around line 35-92: Add accessible aria-label values to all four icon-only
Buttons in the MemoQuickActions action group: use the existing translated action
text for pin/unpin, edit, archive/restore, and delete. Keep the labels dynamic
where the button action changes based on memo.pinned or isArchived.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 520f7d38-be32-47e9-a335-c06baecc265a
📒 Files selected for processing (4)
web/src/components/MemoView/components/MemoHeader.tsxweb/src/components/MemoView/components/MemoQuickActions.tsxweb/src/components/Settings/PreferencesSection.tsxweb/src/locales/en.json
Comment on lines
+35
to
+92
| <div className="hidden sm:group-hover:flex items-center gap-0.5"> | ||
| {!isComment && !isArchived && ( | ||
| <TooltipProvider> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button variant="ghost" size="icon" className="size-6" onClick={handleTogglePinMemoBtnClick}> | ||
| {memo.pinned ? ( | ||
| <BookmarkMinusIcon className="w-4 h-auto text-muted-foreground" /> | ||
| ) : ( | ||
| <BookmarkPlusIcon className="w-4 h-auto text-muted-foreground" /> | ||
| )} | ||
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent>{memo.pinned ? t("common.unpin") : t("common.pin")}</TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> | ||
| )} | ||
|
|
||
| {!isArchived && ( | ||
| <TooltipProvider> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button variant="ghost" size="icon" className="size-6" onClick={handleEditMemoClick}> | ||
| <Edit3Icon className="w-4 h-auto text-muted-foreground" /> | ||
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent>{t("common.edit")}</TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> | ||
| )} | ||
|
|
||
| {!isComment && ( | ||
| <TooltipProvider> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button variant="ghost" size="icon" className="size-6" onClick={handleToggleMemoStatusClick}> | ||
| {isArchived ? ( | ||
| <ArchiveRestoreIcon className="w-4 h-auto text-muted-foreground" /> | ||
| ) : ( | ||
| <ArchiveIcon className="w-4 h-auto text-muted-foreground" /> | ||
| )} | ||
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent>{isArchived ? t("common.restore") : t("common.archive")}</TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> | ||
| )} | ||
|
|
||
| <TooltipProvider> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button variant="ghost" size="icon" className="size-6" onClick={handleDeleteMemoClick}> | ||
| <TrashIcon className="w-4 h-auto text-muted-foreground" /> | ||
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent>{t("common.delete")}</TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> |
Contributor
There was a problem hiding this comment.
Add aria-label to icon-only buttons for screen reader accessibility.
All four action buttons contain only icons with no text or aria-label. Radix Tooltip sets aria-describedby (a description), not aria-label (the accessible name). Screen readers will announce "button" without identifying the action, failing WCAG 4.1.2.
[accessibility]
♿ Proposed fix: add `aria-label` to each button
<Button variant="ghost" size="icon" className="size-6" onClick={handleTogglePinMemoBtnClick}>
+ aria-label={memo.pinned ? t("common.unpin") : t("common.pin")}
{memo.pinned ? ( <Button variant="ghost" size="icon" className="size-6" onClick={handleEditMemoClick}>
+ aria-label={t("common.edit")}
<Edit3Icon className="w-4 h-auto text-muted-foreground" /> <Button variant="ghost" size="icon" className="size-6" onClick={handleToggleMemoStatusClick}>
+ aria-label={isArchived ? t("common.restore") : t("common.archive")}
{isArchived ? ( <Button variant="ghost" size="icon" className="size-6" onClick={handleDeleteMemoClick}>
+ aria-label={t("common.delete")}
<TrashIcon className="w-4 h-auto text-muted-foreground" />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/components/MemoView/components/MemoQuickActions.tsx` around lines 35
- 92, Add accessible aria-label values to all four icon-only Buttons in the
MemoQuickActions action group: use the existing translated action text for
pin/unpin, edit, archive/restore, and delete. Keep the labels dynamic where the
button action changes based on memo.pinned or isArchived.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6055
Summary
Adds optional quick-action buttons (pin, edit, archive, delete) that appear on hover over memo cards. The feature is disabled by default and can be enabled from Settings → Preferences → Behavior.
Changes
MemoQuickActionscomponent.MemoHeaderwhile preserving the existing overflow menu.Behaviour
Testing
pnpm lintpnpm build