fix(hypervisors): fix SupportsSharedfs for CloudHypervisor and add unit tests - #1045
Draft
Norway-02 wants to merge 1 commit into
Draft
fix(hypervisors): fix SupportsSharedfs for CloudHypervisor and add unit tests#1045Norway-02 wants to merge 1 commit into
Norway-02 wants to merge 1 commit into
Conversation
…it tests Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sure — here is the entire GitHub PR description in one copy-paste box:
However, throughout
urunc, the shared filesystem type may be specified as either"virtio"or"virtiofs"(for example, inBuildExecCmd,shared_fs.go, and OCI annotations).As a result:
incorrectly returned
false, causing validvirtiofsshared filesystem configurations to be rejected.Changes
This PR:
Updates
SupportsSharedfsto support both"virtio"and"virtiofs".Adds
cloud_hypervisor_test.gowith unit tests covering:SupportsSharedfsBuildExecCmdUsesKVMPathOkPreExecUpdated Implementation
Testing
Unit Tests
Ran:
go test -v -cover ./pkg/unikontainers/hypervisors/...All tests in
pkg/unikontainers/hypervisorspassed successfully, including:TestCloudHypervisorSupportsSharedfsTestCloudHypervisorBuildExecCmdThe test suite completed with 100% success.
Formatting
gofmt -s -w pkg/unikontainers/hypervisors/*.goStatic Analysis
go vetcompleted successfully.Related Issues
Fixes #NONE
LLM Usage
None.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker, ormake test_crictl).Release Note