[fadiroot]

What type of PR is this?

• bug

What this PR does / why we need it:

With UseShortOptionHandling, a flag that is not found as a whole is split into single-rune flags. Each of those was looked up with lookupFlag, which walks the whole Lineage() and ignores Local. The normal parse path uses lookupAppliedFlag, which only sees the command's own flags plus the persistent ones inherited from its ancestors.

So with

cmd := &Command{Name: "app", UseShortOptionHandling: true,
    Flags: []Flag{&BoolFlag{Name: "debug", Aliases: []string{"d"}, Local: true}},
    Commands: []*Command{{Name: "sub", Flags: []Flag{&BoolFlag{Name: "x"}}}}}

app sub -xd and app sub -d are accepted and set the parent's debug flag (its Action never runs either, since it is not among the child's applied flags), while app sub --debug is rejected with flag provided but not defined, as TestLocalFlagError asserts. FlagBase.Local documents that a Local flag is not applied to subcommands.

• command_parse.go: use lookupAppliedFlag for the split single-rune flags, same as the whole-flag path.
• command_test.go: TestCommand_UseShortOptionHandling_LocalFlagNotInherited covers -xd, -dx, -d (all rejected) and checks the subcommand's own short flags still work in a group. It fails on main and passes with this change; the full suite passes.

Note: #2443 also touches this loop (pre-checking every flag of a group). The two changes are independent; if that lands first this is a one-identifier rebase.

Release Notes

A parent's `Local` flag is no longer accepted by subcommands when given inside a short option group.

[Juneezee]

I think something went wrong with your rebase and force-push. Please check your commits and changes

[fadiroot]

Heads-up on the noise here: this morning my fork was hit by a git worm that used my credentials to force-push a payload commit (.vscode/tasks.json + public/fonts/* + an obfuscated blob in a config file) over the head of every branch, including this PR's. I've restored the branch to the original commit, so the PR is back to only the intended files. Nothing else changed; sorry for the confusion, and please double-check the diff before merging.

[fadiroot]

@Juneezee you were right, but it wasn't a rebase: a git worm used my credentials this morning to force-push a payload commit over every branch in my fork (.vscode/tasks.json, public/fonts/*). The branch is restored to the original commit, so the PR is again only the two intended files (command_parse.go + command_test.go), CI is green. Could you take another look? Sorry for the noise.