fix: normalize line endings via .gitattributes - #68
Merged
Conversation
|
@ApexYash11 is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
ivoIturrieta
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
What & why
There was no
.gitattributesandprettier.config.jsdoesn't overrideendOfLine. On Windows with the commoncore.autocrlf=truecheckout, every file is checked out with\r\nline endings, so:npm run lint(prettier --check .) flags all 26 files as having style issues (Prettier defaults toendOfLine: 'lf').npm run formatwould rewrite the whole tree, creating huge diffs and blocking Windows contributors.Change
Add a
.gitattributesthat normalizes text files to LF:This makes
npm run lint/npm run formatbehave identically on Windows and Linux/CI. It is a zero-runtime-risk change.Verification
prettier --check .reported issues in 26/26 files (all CRLF).prettier --check srcreportsAll matched files use Prettier code style!.npm run typecheckandnpm testare unaffected (no runtime code changed).