chore: gitignore lockfiles from other package managers - #53
Open
sidgaikwad wants to merge 1 commit into
Open
Conversation
npm is clearly the intended package manager — both package-lock.json files are committed and CI runs `npm ci` — but nothing stopped a stray lockfile from another resolver being committed. Running `bun install` on a fresh clone leaves bun.lock and demo/bun.lock untracked and rewrites demo/package-lock.json in place, with nothing in the repo signalling that is wrong. Two lockfiles in the tree is exactly the state that makes `npm ci` fail confusingly for the next person. Ignore bun/pnpm/yarn lockfiles and state the supported package manager in CONTRIBUTING.
|
@sidgaikwad is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45.
npm is clearly the intended package manager — both
package-lock.jsonfiles are committed, CI runsnpm ci, and CONTRIBUTING documentsnpm installthroughout. But.gitignoredidn't mention any other lockfile.I hit this on a fresh clone: running
bun installleftbun.lockanddemo/bun.lockuntracked and rewrotedemo/package-lock.jsonin place, with nothing in the repo signalling that was wrong. Onegit add .and the repo has two lockfiles — the state that makesnpm cifail confusingly for whoever clones next.Change
bun.lock,bun.lockb,pnpm-lock.yaml,yarn.lock.Verification
Deliberately not included
The issue also floated a
packageManagerfield (Corepack) or anengines.npmconstraint to make the wrong tool fail loudly rather than quietly. That's a stronger guarantee but a bigger behavioural change for contributors, so I left it as a separate call for you — happy to add it if you want it.