chore: require Node >= 20 - #52
Open
sidgaikwad wants to merge 1 commit into
Open
Conversation
`engines.node` claimed `>=18` and CONTRIBUTING repeated it, but the CI matrix is 20/22/24 — Node 18 was never exercised, and it reached end-of-life in April 2025. Align all three statements on the version range that is actually tested. npm only warns on an `engines` mismatch by default, so this does not hard- break an existing Node 18 install; it corrects the signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.
package.jsonclaimed"engines": { "node": ">=18" }and CONTRIBUTING.md repeated it, but the CI matrix is[20, 22, 24]— Node 18 was claimed as supported and never exercised. It also reached end-of-life in April 2025.Of the two resolutions in the issue, this takes the first: drop the claim rather than add an EOL runtime to the matrix. That aligns all three statements —
engines, CONTRIBUTING.md, and the CI matrix — on the range that is actually tested.npm only warns on an
enginesmismatch by default, so this doesn't hard-break anyone still on 18; it corrects a signal that was wrong.Happy to flip it to "add 18 to the matrix" instead if you'd rather keep supporting it — just say and I'll swap the PR.