ci: typecheck and build the demo - #51
Merged
Merged
Conversation
The demo is aliased straight to ../src and is the project's only integration harness, but nothing in CI touched it — a change to the component's public surface could break it and still show a green build. The demo is also the live demo linked from the README, so a break there is user-facing. Add a `demo` job that installs both workspaces and runs typecheck + build, a `typecheck` script in demo/package.json to back it, and a Dependabot entry for /demo so its dependencies stop drifting behind the root.
|
@sidgaikwad is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
ivoIturrieta
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Problem
CI never touched
demo/. Both jobs ran only at the repo root, so nothing installed, typechecked or built the demo — even though it:../src(demo/vite.config.ts), making it the project's only integration harness for the component's public surfaceIt was already drifting:
demo/package.jsonpins@unlayer/types@1.448.0while the root pins1.477.0, and nothing noticed.Change
demojob that installs both workspaces and runs typecheck + build. The rootnpm ciis needed first because the alias resolves into the parent.typecheckscript indemo/package.json— it had none, so there was nothing for CI to call./demoentry in.github/dependabot.yml, grouped, so the demo's dependencies stop drifting behind the root.Verification
Ran the exact job steps locally against this tree:
Two notes for the reviewer
@unlayer/typesbump out of this PR to keep it CI-scoped. I did verify separately that1.477.0typechecks and builds clean in the demo, so the Dependabot PR this change enables should be safe to merge..github/workflows/ci.yml, so it will conflict with ci: add permissions, a concurrency group, and pin actions to SHAs #50 (SHA-pinning). The hunks are far apart and should merge cleanly, but whichever lands second will want the newdemojob'suses:lines pinned to match. Happy to rebase whichever order you prefer.