shouldExpandNodeInitially causes a confusing visual bug where the array looks like an empty array, objects behave similar #76

Activity

1. jaywcjlove

   added a commit that references this issue on Aug 16, 2025

   fix: fix shouldExpandNodeInitially display bug. #76

   c76a9ee
2. github-actions

   added a commit that references this issue on Aug 16, 2025

   fix: fix shouldExpandNodeInitially display bug. #76 c76a9ee

   d628f1f
3. jaywcjlove

   added a commit that references this issue on Aug 16, 2025

   released v2.0.0-alpha.35 #76

   83dcd53
4. jaywcjlove commented on Aug 16, 2025

   

   jaywcjlove

   on Aug 16, 2025

   Member

   More actions

   

   react-json-view/example/src/demo.tsx

   Lines 33 to 49 in c76a9ee

   	const shouldExpandNodeInitially: ShouldExpandNodeInitially<object> = (isExpanded, props) => {
   	const { value, level, keyName, parentValue, keys } = props;
   	console.log('~~~~:', keyName, level, parentValue, keys);
   	const isArray = Array.isArray(value);
   	const isObject = typeof value === 'object' && !isArray;
   	if (isArray) {
   	return isExpanded || value.length > 5;
   	}
   	if (isObject && level > 3) {
   	return isExpanded || true; // Expand if it's an object and level is greater than 3
   	}
   	return isExpanded;
   	};
   	export default function App() {
   	return <JsonView value={example} displayObjectSize={false} shouldExpandNodeInitially={shouldExpandNodeInitially} />;
   	}

   @Seigiard Looks like I’ve fixed it

   🎉React with 🎉1Reacted by Borisenko Andrew
5. github-actions

   added a commit that references this issue on Aug 16, 2025

   released v2.0.0-alpha.35 #76 83dcd53

   0596cd3
6. Seigiard

   closed this as completedon Aug 23, 2025
7. Seigiard commented on Aug 23, 2025

   

   Seigiard

   on Aug 23, 2025

   Author

   More actions

   Confirmed! Works like a charm!
8. jaywcjlove

   added 3 commits that reference this issue on Sep 17, 2025

   fix: default shouldExpandNodeInitially to false for collapsed nodes. #59

   ...

   e4ea21d

   released v2.0.0-alpha.38 #59 #76

   e3734c9

   fix: default shouldExpandNodeInitially to false for collapsed nodes. #59

   ...

   87a29ec
9. github-actions

   added a commit that references this issue on Sep 17, 2025

   fix: default shouldExpandNodeInitially to false for collapsed nodes. #59

   ...

   82fd447