Repository navigation
feat(handler): add handler package acting as passthrough to controller - #328
Merged
Merged
Conversation
Add the handler package as a pure passthrough. The handler takes the existing proto-typed controller and forwards GetTargetGraph, GetChangedTargets and GetChangedTargetGraph to it unchanged. The handler does not validate, map, filter, chunk, convert errors or record metrics, so metrics do not double count. Export a controller.Controller interface and generate controller/controllermock from it. The handler depends on the interface, and the handler tests use the generated mock. Register the handler in example/main.go and in the integration test instead of the controller. This starts a step-by-step move of the transport layer out of the controller. Test plan: - go test ./handler/... checks that each method forwards its arguments and returns the error of the controller. - make build, make test and make lint pass. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
justinwon777
force-pushed
the
justin.won/handler-passthrough
branch
from
October 8, 2026 08:12
4660a94 to
30bd419
Compare
xytan0056
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the handler package as a pure passthrough. The handler takes the existing proto-typed controller and forwards GetTargetGraph, GetChangedTargets and GetChangedTargetGraph to it unchanged. Code in controller will be migrated to handler in later PRs.
Register the handler in example/main.go and in the integration test instead of the controller. This starts a step-by-step move of the transport layer out of the controller.
Test plan:
Issue
#325